You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@aurora.apache.org by jf...@apache.org on 2015/09/17 18:25:18 UTC
aurora git commit: AURORA-1485: TaskConfig default container value
breaks client library generation for GO
Repository: aurora
Updated Branches:
refs/heads/master 9dff05714 -> d98bfc8f4
AURORA-1485: TaskConfig default container value breaks client library generation for GO
When generating the client api library for go the default containerizer used as a hack for AURORA-1185 breaks and causes the client lib to not be generated correctly. The default value for the optional field `container = { "mesos": {} }` is not necessary as it is defaulted in java code on the api side.
Tracking this down it looks like the default value was a last minute addition based on some review comments and is not necessary or used anywhere.
Testing Done:
Passes all java/py tests in ./build-support/jenkins/build.sh
Passes all e2e tests in ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Bugs closed: AURORA-1485
Reviewed at https://reviews.apache.org/r/38389/
Project: http://git-wip-us.apache.org/repos/asf/aurora/repo
Commit: http://git-wip-us.apache.org/repos/asf/aurora/commit/d98bfc8f
Tree: http://git-wip-us.apache.org/repos/asf/aurora/tree/d98bfc8f
Diff: http://git-wip-us.apache.org/repos/asf/aurora/diff/d98bfc8f
Branch: refs/heads/master
Commit: d98bfc8f4f7bb583b81f052903bfb39b632f0dbf
Parents: 9dff057
Author: Jake Farrell <jf...@apache.org>
Authored: Thu Sep 17 12:24:41 2015 -0400
Committer: jfarrell <jf...@apache.org>
Committed: Thu Sep 17 12:24:41 2015 -0400
----------------------------------------------------------------------
api/src/main/thrift/org/apache/aurora/gen/api.thrift | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/aurora/blob/d98bfc8f/api/src/main/thrift/org/apache/aurora/gen/api.thrift
----------------------------------------------------------------------
diff --git a/api/src/main/thrift/org/apache/aurora/gen/api.thrift b/api/src/main/thrift/org/apache/aurora/gen/api.thrift
index 24a2ca8..a04e644 100644
--- a/api/src/main/thrift/org/apache/aurora/gen/api.thrift
+++ b/api/src/main/thrift/org/apache/aurora/gen/api.thrift
@@ -272,7 +272,7 @@ struct TaskConfig {
// This field is deliberately placed at the end to work around a bug in the immutable wrapper
// code generator. See AURORA-1185 for details.
/** the container the task should use to execute */
- 29: optional Container container = { "mesos": {} }
+ 29: Container container = { "mesos": {} }
}
/** Defines the policy for launching a new cron job when one is already running. */