[jira] [Commented] (HDFS-8180) AbstractFileSystem Implementation for WebHdfs

["Jakob Homan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14544340#comment-14544340 ] 

Jakob Homan commented on HDFS-8180:
-----------------------------------

Hey Santhosh-
   Thanks for the update.  A couple minor changes and I'll be ready to commit this:

* The two tests have quite a lot (say 70%) of duplicated code.  Can we have TestSWebHdfsFileContextMainOperations extend TestWebHdfsFileContextMainOperations?  This is particularly true since there are comments about the need to add more testing/verification on WebHDFS versus HDFS behavior in both tests.  Not sure if you'll run into problems with the JUnit {{@BeforeClass}} annotations.  If so, just go ahead and split out the common code to another, non-test class.
* The comments about WebHDFS/HDFS behavior are formatted incorrectly and run into their function definitions:
{noformat}  @Test
  /** Test FileContext APIs when symlinks are not supported
   * TODO: Open separate JIRA for full support of the Symlink in webhdfs
   * */ public void testUnsupportedSymlink() throws IOException {{noformat}
* Typo: clusterSetupAtBegining > clusterSetupAtBeginning



> AbstractFileSystem Implementation for WebHdfs
> ---------------------------------------------
>
>                 Key: HDFS-8180
>                 URL: https://issues.apache.org/jira/browse/HDFS-8180
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>          Components: webhdfs
>    Affects Versions: 2.6.0
>            Reporter: Santhosh G Nayak
>            Assignee: Santhosh G Nayak
>              Labels: hadoop
>         Attachments: HDFS-8180-1.patch, HDFS-8180-2.patch
>
>
> Add AbstractFileSystem implementation for WebHdfs to support FileContext APIs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)