You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/01 09:05:02 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #681:
Dns the dual stack support(part 2)
xiaoxiang781216 opened a new pull request #681: Dns the dual stack support(part 2)
URL: https://github.com/apache/incubator-nuttx/pull/681
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #681:
Dns the dual stack support(part 2)
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #681: Dns the dual stack support(part 2)
URL: https://github.com/apache/incubator-nuttx/pull/681#discussion_r401641286
##########
File path: libs/libc/netdb/lib_gethostbyaddrr.c
##########
@@ -61,8 +60,10 @@
struct hostent_info_s
{
+ int hi_addrtypes[CONFIG_NETDB_MAX_IPADDR + 1];
+ int hi_lengths[CONFIG_NETDB_MAX_IPADDR + 1];
Review comment:
if they are not necessary, yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #681: Dns the dual
stack support(part 2)
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #681: Dns the dual stack support(part 2)
URL: https://github.com/apache/incubator-nuttx/pull/681#issuecomment-607514513
>
>
> @patacongo the PR has fixed all comments from @yamt , please help review and merge it. If you have any new suggestion, let me know.
Will do...
I looked through the changes and saw no issues. But I am not fully up to speed with all of what you are trying to do. I have noted all of the review comments and dialog, so I am confident that this has had a good review by others.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #681:
Dns the dual stack support(part 2)
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on issue #681: Dns the dual stack support(part 2)
URL: https://github.com/apache/incubator-nuttx/pull/681#issuecomment-607395858
@patacongo the PR has fixed all comments from @yamt , please help review and merge it. If you have any new suggestion, let me know.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo merged pull request #681: Dns the dual
stack support(part 2)
Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #681: Dns the dual stack support(part 2)
URL: https://github.com/apache/incubator-nuttx/pull/681
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #681: Dns the dual stack support(part 2)
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #681: Dns the dual stack support(part 2)
URL: https://github.com/apache/incubator-nuttx/pull/681#discussion_r401562921
##########
File path: libs/libc/netdb/lib_gethostbyaddrr.c
##########
@@ -61,8 +60,10 @@
struct hostent_info_s
{
+ int hi_addrtypes[CONFIG_NETDB_MAX_IPADDR + 1];
+ int hi_lengths[CONFIG_NETDB_MAX_IPADDR + 1];
Review comment:
Yes, it isn't necessary, but it make the struct neat and orderly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #681: Dns the dual stack support(part 2)
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #681: Dns the dual stack support(part 2)
URL: https://github.com/apache/incubator-nuttx/pull/681#discussion_r401655488
##########
File path: libs/libc/netdb/lib_gethostbyaddrr.c
##########
@@ -61,8 +60,10 @@
struct hostent_info_s
{
+ int hi_addrtypes[CONFIG_NETDB_MAX_IPADDR + 1];
+ int hi_lengths[CONFIG_NETDB_MAX_IPADDR + 1];
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #681: Dns the
dual stack support(part 2)
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #681: Dns the dual stack support(part 2)
URL: https://github.com/apache/incubator-nuttx/pull/681#issuecomment-607130097
Close https://github.com/apache/incubator-nuttx/pull/664 accidentally, recreate again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #681:
Dns the dual stack support(part 2)
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #681: Dns the dual stack support(part 2)
URL: https://github.com/apache/incubator-nuttx/pull/681#discussion_r401556825
##########
File path: libs/libc/netdb/lib_gethostbyaddrr.c
##########
@@ -61,8 +60,10 @@
struct hostent_info_s
{
+ int hi_addrtypes[CONFIG_NETDB_MAX_IPADDR + 1];
+ int hi_lengths[CONFIG_NETDB_MAX_IPADDR + 1];
Review comment:
is "+ 1" necessary?
hi_addrlist needs +1 for terminating NULL. i guess these two don't.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #681: Dns the dual stack support(part 2)
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #681: Dns the dual stack support(part 2)
URL: https://github.com/apache/incubator-nuttx/pull/681#discussion_r401618296
##########
File path: libs/libc/netdb/lib_gethostbyaddrr.c
##########
@@ -61,8 +60,10 @@
struct hostent_info_s
{
+ int hi_addrtypes[CONFIG_NETDB_MAX_IPADDR + 1];
+ int hi_lengths[CONFIG_NETDB_MAX_IPADDR + 1];
Review comment:
@yamt do you want to remove +1?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #681: Dns the
dual stack support(part 2)
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #681: Dns the dual stack support(part 2)
URL: https://github.com/apache/incubator-nuttx/pull/681#issuecomment-607395858
@patacongo the PR has fixed all comments from @yamt , please help review and merge it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #681: Dns the
dual stack support(part 2)
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #681: Dns the dual stack support(part 2)
URL: https://github.com/apache/incubator-nuttx/pull/681#issuecomment-607132868
@yamt The new PR should resolve your concern, please review the change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services