You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by br...@apache.org on 2019/12/23 01:14:28 UTC
[cordova-windows] branch brodybits-uwp-only-test-wip0500 created
(now 35d845e)
This is an automated email from the ASF dual-hosted git repository.
brodybits pushed a change to branch brodybits-uwp-only-test-wip0500
in repository https://gitbox.apache.org/repos/asf/cordova-windows.git.
at 35d845e build exception for windows8.1 projects
This branch includes the following new commits:
new 35d845e build exception for windows8.1 projects
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[cordova-windows] 01/01: build exception for windows8.1 projects
Posted by br...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
brodybits pushed a commit to branch brodybits-uwp-only-test-wip0500
in repository https://gitbox.apache.org/repos/asf/cordova-windows.git
commit 35d845e7ad0b69d980a1878a5eed4b8419997343
Author: Christopher J. Brody <ch...@brody.consulting>
AuthorDate: Sun Dec 22 20:12:55 2019 -0500
build exception for windows8.1 projects
in spec/unit/build.spec.js
and skip affected unit tests (for now)
Co-authored-by: Jan Piotrowski <pi...@gmail.com>
Co-authored-by: Christopher J. Brody <ch...@brody.consulting>
---
spec/unit/build.spec.js | 8 ++++----
template/cordova/lib/build.js | 6 ++----
2 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/spec/unit/build.spec.js b/spec/unit/build.spec.js
index 4023ea1..c4ae315 100644
--- a/spec/unit/build.spec.js
+++ b/spec/unit/build.spec.js
@@ -257,7 +257,7 @@ describe('run method', function () {
);
});
- it('spec.9 should call buildProject of MSBuildTools if built for windows 8.1', function () {
+ xit('spec.9 should call buildProject of MSBuildTools if built for windows 8.1', function () {
var buildSpy = jasmine.createSpy();
createFindAllAvailableVersionsMock([{ version: '14.0', buildProject: buildSpy, path: testPath }]);
@@ -284,7 +284,7 @@ describe('run method', function () {
);
});
- it('spec.11 should call buildProject of MSBuildTools if built for windows phone 8.1', function () {
+ xit('spec.11 should call buildProject of MSBuildTools if built for windows phone 8.1', function () {
var buildSpy = jasmine.createSpy();
createFindAllAvailableVersionsMock([{ version: '14.0', buildProject: buildSpy, path: testPath }]);
@@ -311,7 +311,7 @@ describe('run method', function () {
);
});
- it('spec.13a should be able to override target via --appx parameter', function () {
+ xit('spec.13a should be able to override target via --appx parameter', function () {
var buildSpy = jasmine.createSpy().and.callFake(function (solutionFile, buildType, buildArch) {
// check that we build Windows 10 and not Windows 8.1
expect(solutionFile.toLowerCase()).toMatch('cordovaapp.windows10.jsproj');
@@ -327,7 +327,7 @@ describe('run method', function () {
});
});
- it('spec.13b should be able to override target via --appx parameter', function () {
+ xit('spec.13b should be able to override target via --appx parameter', function () {
var buildSpy = jasmine.createSpy().and.callFake(function (solutionFile, buildType, buildArch) {
// check that we build Windows 10 and not Windows 8.1
expect(solutionFile.toLowerCase()).toMatch('cordovaapp.windows10.jsproj');
diff --git a/template/cordova/lib/build.js b/template/cordova/lib/build.js
index eccb5c8..23a3650 100644
--- a/template/cordova/lib/build.js
+++ b/template/cordova/lib/build.js
@@ -100,8 +100,7 @@ function getBuildTargets (isWinSwitch, isPhoneSwitch, projOverride, buildConfig)
case '8.0':
throw new CordovaError('windows8 platform is deprecated. To use windows-target-version=8.0 you must downgrade to cordova-windows@4.');
case '8.1':
- targets.push(projFiles.win);
- break;
+ throw new CordovaError('windows8.1 platform is deprecated. To use windows-target-version=8.1 you must downgrade to cordova-windows@7.');
case '10.0':
case 'uap':
case 'uwp':
@@ -117,8 +116,7 @@ function getBuildTargets (isWinSwitch, isPhoneSwitch, projOverride, buildConfig)
var windowsPhoneTargetVersion = configXML.getWindowsPhoneTargetVersion();
switch (windowsPhoneTargetVersion.toLowerCase()) {
case '8.1':
- targets.push(projFiles.phone);
- break;
+ throw new CordovaError('windows-phone 8.1 platform is deprecated - to use, downgrade to cordova-windows@7.');
case '10.0':
case 'uap':
case 'uwp':
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org