You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/03/30 11:45:01 UTC

[GitHub] [iotdb] HTHou commented on a change in pull request #5382: [IOTDB-2650] Tablet supports adding String value

HTHou commented on a change in pull request #5382:
URL: https://github.com/apache/iotdb/pull/5382#discussion_r838445154



##########
File path: tsfile/src/main/java/org/apache/iotdb/tsfile/write/record/Tablet.java
##########
@@ -138,7 +138,7 @@ private void addValueOfDataType(
       case TEXT:
         {
           Binary[] sensor = (Binary[]) values[indexOfSchema];
-          sensor[rowIndex] = value != null ? (Binary) value : Binary.EMPTY_VALUE;
+          sensor[rowIndex] = value != null ? new Binary((String) value) : Binary.EMPTY_VALUE;

Review comment:
       Thanks for your contribution!
   
   IMO, we should also support adding a Binary value here to keep the compatibility. :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org