You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/08/08 02:09:04 UTC
Review Request 24485: Allowed flags to load from a configure file as
defaults.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24485/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ben Mahler, Dominic Hamon, and Vinod Kone.
Bugs: MESOS-1651
https://issues.apache.org/jira/browse/MESOS-1651
Repository: mesos-git
Description
-------
See ticket for details. When parsing flags, users now can specify a file to be used as defaults. The command line arguments will override the defaults specified in the configure file. The file is a JSON object:
{
"flag1" : "string",
"flag2" : true,
"flag3" : 10,
"flag4" : { "a" : 1, "b" : 2}
..
}
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 112dcb1
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 3b60ff8
src/tests/main.cpp 442be51
Diff: https://reviews.apache.org/r/24485/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 24485: Allowed flags to load from a configure file as
defaults.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24485/#review50147
-----------------------------------------------------------
Patch looks great!
Reviews applied: [24485]
All tests passed.
- Mesos ReviewBot
On Aug. 8, 2014, 12:09 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24485/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2014, 12:09 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Dominic Hamon, and Vinod Kone.
>
>
> Bugs: MESOS-1651
> https://issues.apache.org/jira/browse/MESOS-1651
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See ticket for details. When parsing flags, users now can specify a file to be used as defaults. The command line arguments will override the defaults specified in the configure file. The file is a JSON object:
>
> {
> "flag1" : "string",
> "flag2" : true,
> "flag3" : 10,
> "flag4" : { "a" : 1, "b" : 2}
> ..
> }
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 112dcb1
> 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 3b60ff8
> src/tests/main.cpp 442be51
>
> Diff: https://reviews.apache.org/r/24485/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24485: Allowed flags to load from a configure file as
defaults.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24485/#review50041
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp
<https://reviews.apache.org/r/24485/#comment87556>
i think this is the fundamentally wrong approach. more in the ticket.
- Dominic Hamon
On Aug. 7, 2014, 5:09 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24485/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2014, 5:09 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Dominic Hamon, and Vinod Kone.
>
>
> Bugs: MESOS-1651
> https://issues.apache.org/jira/browse/MESOS-1651
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See ticket for details. When parsing flags, users now can specify a file to be used as defaults. The command line arguments will override the defaults specified in the configure file. The file is a JSON object:
>
> {
> "flag1" : "string",
> "flag2" : true,
> "flag3" : 10,
> "flag4" : { "a" : 1, "b" : 2}
> ..
> }
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 112dcb1
> 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 3b60ff8
> src/tests/main.cpp 442be51
>
> Diff: https://reviews.apache.org/r/24485/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24485: Allowed flags to load from a configure file as
defaults.
Posted by Tobias Weingartner <tw...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24485/#review50037
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp
<https://reviews.apache.org/r/24485/#comment87548>
s/defaults/config/
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp
<https://reviews.apache.org/r/24485/#comment87546>
Nasty tossing away const like this... :)
- Tobias Weingartner
On Aug. 8, 2014, 12:09 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24485/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2014, 12:09 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Dominic Hamon, and Vinod Kone.
>
>
> Bugs: MESOS-1651
> https://issues.apache.org/jira/browse/MESOS-1651
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See ticket for details. When parsing flags, users now can specify a file to be used as defaults. The command line arguments will override the defaults specified in the configure file. The file is a JSON object:
>
> {
> "flag1" : "string",
> "flag2" : true,
> "flag3" : 10,
> "flag4" : { "a" : 1, "b" : 2}
> ..
> }
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 112dcb1
> 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 3b60ff8
> src/tests/main.cpp 442be51
>
> Diff: https://reviews.apache.org/r/24485/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24485: Allowed flags to load from a configure file as
defaults.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24485/#review49984
-----------------------------------------------------------
This is similar to how MySQL deals with my.cnf. All configures in my.cnf are defaults (which will be overridden by command arguments).
- Jie Yu
On Aug. 8, 2014, 12:09 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24485/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2014, 12:09 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Dominic Hamon, and Vinod Kone.
>
>
> Bugs: MESOS-1651
> https://issues.apache.org/jira/browse/MESOS-1651
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See ticket for details. When parsing flags, users now can specify a file to be used as defaults. The command line arguments will override the defaults specified in the configure file. The file is a JSON object:
>
> {
> "flag1" : "string",
> "flag2" : true,
> "flag3" : 10,
> "flag4" : { "a" : 1, "b" : 2}
> ..
> }
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 112dcb1
> 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 3b60ff8
> src/tests/main.cpp 442be51
>
> Diff: https://reviews.apache.org/r/24485/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>