You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by srdo <gi...@git.apache.org> on 2018/11/20 13:54:12 UTC

[GitHub] storm pull request #2913: STORM-3290: Split configuration for storm-kafka-cl...

GitHub user srdo opened a pull request:

    https://github.com/apache/storm/pull/2913

    STORM-3290: Split configuration for storm-kafka-client Trident and no…

    …n-Trident spout into two classes.
    
    https://issues.apache.org/jira/browse/STORM-3290
    
    This moves configuration used by both Trident and non-Trident spouts into a common superclass, and makes a new config class for the Trident spouts.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/srdo/storm STORM-3290

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2913.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2913
    
----
commit b879245af12231d41a9c18aad5e7cbdbd66312d0
Author: Stig Rohde Døssing <sr...@...>
Date:   2018-11-20T12:03:25Z

    STORM-3290: Split configuration for storm-kafka-client Trident and non-Trident spout into two classes

----


---

[GitHub] storm issue #2913: STORM-3290: Split configuration for storm-kafka-client Tr...

Posted by srdo <gi...@git.apache.org>.

Github user srdo commented on the issue:

    https://github.com/apache/storm/pull/2913
  
    Thanks for reviewing, merged to master.


---

[GitHub] storm pull request #2913: STORM-3290: Split configuration for storm-kafka-cl...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/2913


---

[GitHub] storm issue #2913: STORM-3290: Split configuration for storm-kafka-client Tr...

Posted by hmcl <gi...@git.apache.org>.

Github user hmcl commented on the issue:

    https://github.com/apache/storm/pull/2913
  
    +1


---

[GitHub] storm issue #2913: STORM-3290: Split configuration for storm-kafka-client Tr...

Posted by ptgoetz <gi...@git.apache.org>.

Github user ptgoetz commented on the issue:

    https://github.com/apache/storm/pull/2913
  
    +1


---