You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/01/03 19:02:54 UTC
[GitHub] [accumulo] foster33 opened a new pull request #2407: Correct user-facing misspellings (Part 2)
foster33 opened a new pull request #2407:
URL: https://github.com/apache/accumulo/pull/2407
This pull request serves to correct more mistakes in potential user-facing areas.
In my first PR regarding misspellings (#2400), I did not include mistakes found in Javadocs. Most of the corrections in this PR focus on Javadoc as well as a few other mistakes that were overlooked in the original.
This will be my final PR that focuses on misspellings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] DomGarguilo merged pull request #2407: Correct user-facing misspellings (Part 2)
Posted by GitBox <gi...@apache.org>.
DomGarguilo merged pull request #2407:
URL: https://github.com/apache/accumulo/pull/2407
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] DomGarguilo commented on a change in pull request #2407: Correct user-facing misspellings (Part 2)
Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on a change in pull request #2407:
URL: https://github.com/apache/accumulo/pull/2407#discussion_r777661535
##########
File path: start/src/main/java/org/apache/accumulo/start/spi/KeywordExecutable.java
##########
@@ -28,7 +28,7 @@
* All implementing classes who have an entry in
* META-INF/services/{@link org.apache.accumulo.start.spi.KeywordExecutable} on the classpath will
* be constructed by the {@link ServiceLoader}, so they should be lightweight and quickly
- * constructible with a mandatory no-argument constructor. Because of this, implementing classes
Review comment:
Looks like its debatable but "constructible" might be the correct US-en spelling.
Edit: source: https://www.lexico.com/search?filter=en_dictionary&query=constructable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] DomGarguilo commented on a change in pull request #2407: Correct user-facing misspellings (Part 2)
Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on a change in pull request #2407:
URL: https://github.com/apache/accumulo/pull/2407#discussion_r777661535
##########
File path: start/src/main/java/org/apache/accumulo/start/spi/KeywordExecutable.java
##########
@@ -28,7 +28,7 @@
* All implementing classes who have an entry in
* META-INF/services/{@link org.apache.accumulo.start.spi.KeywordExecutable} on the classpath will
* be constructed by the {@link ServiceLoader}, so they should be lightweight and quickly
- * constructible with a mandatory no-argument constructor. Because of this, implementing classes
Review comment:
Looks like its debatable but "constructible" might be the correct US-en spelling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] Manno15 commented on pull request #2407: Correct user-facing misspellings (Part 2)
Posted by GitBox <gi...@apache.org>.
Manno15 commented on pull request #2407:
URL: https://github.com/apache/accumulo/pull/2407#issuecomment-1004307393
:+1: to 'constructible'
On Mon, Jan 3, 2022 at 2:23 PM Dom G. ***@***.***> wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In
> start/src/main/java/org/apache/accumulo/start/spi/KeywordExecutable.java
> <https://github.com/apache/accumulo/pull/2407#discussion_r777661535>:
>
> > @@ -28,7 +28,7 @@
> * All implementing classes who have an entry in
> * ***@***.*** org.apache.accumulo.start.spi.KeywordExecutable} on the classpath will
> * be constructed by the ***@***.*** ServiceLoader}, so they should be lightweight and quickly
> - * constructible with a mandatory no-argument constructor. Because of this, implementing classes
>
> Looks like its debatable but "constructible" might be the correct US-en
> spelling.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/accumulo/pull/2407#pullrequestreview-842982779>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AHASSV2TNXOWHEURZV7SWQ3UUHZUBANCNFSM5LFZZUWA>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
> You are receiving this because you are subscribed to this thread.Message
> ID: ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] foster33 commented on a change in pull request #2407: Correct user-facing misspellings (Part 2)
Posted by GitBox <gi...@apache.org>.
foster33 commented on a change in pull request #2407:
URL: https://github.com/apache/accumulo/pull/2407#discussion_r777664877
##########
File path: start/src/main/java/org/apache/accumulo/start/spi/KeywordExecutable.java
##########
@@ -28,7 +28,7 @@
* All implementing classes who have an entry in
* META-INF/services/{@link org.apache.accumulo.start.spi.KeywordExecutable} on the classpath will
* be constructed by the {@link ServiceLoader}, so they should be lightweight and quickly
- * constructible with a mandatory no-argument constructor. Because of this, implementing classes
Review comment:
I will go ahead and revert this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org