You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by da...@apache.org on 2013/08/16 08:22:28 UTC
[1/2] git commit: ISIS-468: collection columns now ordered correctly
Updated Branches:
refs/heads/master b59b1c323 -> 16854d353
ISIS-468: collection columns now ordered correctly
These were being ordered with the group names alphabetically, rather than with respect to the MemberGroupLayoutFacet.
Project: http://git-wip-us.apache.org/repos/asf/isis/repo
Commit: http://git-wip-us.apache.org/repos/asf/isis/commit/6ec4f414
Tree: http://git-wip-us.apache.org/repos/asf/isis/tree/6ec4f414
Diff: http://git-wip-us.apache.org/repos/asf/isis/diff/6ec4f414
Branch: refs/heads/master
Commit: 6ec4f414f3c2afd3371a5f76e0e8578d1899b530
Parents: b59b1c3
Author: Dan Haywood <da...@apache.org>
Authored: Thu Aug 15 23:23:19 2013 +0100
Committer: Dan Haywood <da...@apache.org>
Committed: Thu Aug 15 23:23:19 2013 +0100
----------------------------------------------------------------------
.../isis/core/metamodel/layout/OrderSet.java | 35 ++++++++++++++++++++
.../layout/memberorderfacet/DeweyOrderSet.java | 3 ++
...mberLayoutArrangerUsingMemberOrderFacet.java | 16 ++++++++-
3 files changed, 53 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/isis/blob/6ec4f414/core/metamodel/src/main/java/org/apache/isis/core/metamodel/layout/OrderSet.java
----------------------------------------------------------------------
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/layout/OrderSet.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/layout/OrderSet.java
index 8385292..9e58f5c 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/layout/OrderSet.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/layout/OrderSet.java
@@ -21,12 +21,14 @@ package org.apache.isis.core.metamodel.layout;
import java.util.ArrayList;
import java.util.Iterator;
+import java.util.LinkedHashMap;
import java.util.List;
import java.util.SortedSet;
import java.util.StringTokenizer;
import java.util.TreeSet;
import com.google.common.collect.Lists;
+import com.google.common.collect.Maps;
import org.apache.isis.core.metamodel.layout.memberorderfacet.DeweyOrderSet;
import org.apache.isis.core.metamodel.spec.feature.ObjectMember;
@@ -193,6 +195,39 @@ public class OrderSet implements Comparable<OrderSet>, Iterable<Object> {
this.addElement(deweyOrderSet);
}
}
+
+ // ///////////////////////// compareTo //////////////////////
+
+ public void reorderChildren(List<String> requiredOrder) {
+ final LinkedHashMap<String,OrderSet> orderSets = Maps.newLinkedHashMap();
+
+ // remove all OrderSets from elements
+ // though remembering the order they were encountered
+ for (Object child : elementList()) {
+ if(child instanceof OrderSet) {
+ final OrderSet orderSet = (OrderSet) child;
+ elements.remove(orderSet);
+ orderSets.put(orderSet.getGroupName(), orderSet);
+ }
+ }
+
+ // spin through the requiredOrder and add back in (if found)
+ for (String group : requiredOrder) {
+ OrderSet orderSet = orderSets.get(group);
+ if(orderSet == null) {
+ continue;
+ }
+ orderSets.remove(group);
+ elements.add(orderSet);
+ }
+
+ // anything left, add back in the original order
+ for (String orderSetGroupName : orderSets.keySet()) {
+ final OrderSet orderSet = orderSets.get(orderSetGroupName);
+ elements.add(orderSet);
+ }
+ }
+
// ///////////////////////// compareTo //////////////////////
http://git-wip-us.apache.org/repos/asf/isis/blob/6ec4f414/core/metamodel/src/main/java/org/apache/isis/core/metamodel/layout/memberorderfacet/DeweyOrderSet.java
----------------------------------------------------------------------
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/layout/memberorderfacet/DeweyOrderSet.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/layout/memberorderfacet/DeweyOrderSet.java
index cc034ac..9546250 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/layout/memberorderfacet/DeweyOrderSet.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/layout/memberorderfacet/DeweyOrderSet.java
@@ -167,6 +167,8 @@ public class DeweyOrderSet extends OrderSet {
super(groupName);
}
+
+
/**
* Format is: <tt>abc,def:XXel/YYm/ZZch</tt>
* <p>
@@ -179,4 +181,5 @@ public class DeweyOrderSet extends OrderSet {
return getGroupFullName() + ":" + size() + "el/" + (size() - childOrderSets.size()) + "m/" + childOrderSets.size() + "ch";
}
+
}
http://git-wip-us.apache.org/repos/asf/isis/blob/6ec4f414/core/metamodel/src/main/java/org/apache/isis/core/metamodel/layout/memberorderfacet/MemberLayoutArrangerUsingMemberOrderFacet.java
----------------------------------------------------------------------
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/layout/memberorderfacet/MemberLayoutArrangerUsingMemberOrderFacet.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/layout/memberorderfacet/MemberLayoutArrangerUsingMemberOrderFacet.java
index e7742b0..3c92ddd 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/layout/memberorderfacet/MemberLayoutArrangerUsingMemberOrderFacet.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/layout/memberorderfacet/MemberLayoutArrangerUsingMemberOrderFacet.java
@@ -18,10 +18,13 @@ package org.apache.isis.core.metamodel.layout.memberorderfacet;
import java.util.List;
+import com.google.common.collect.Lists;
+
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.apache.isis.core.metamodel.facets.FacetedMethod;
+import org.apache.isis.core.metamodel.facets.object.membergroups.MemberGroupLayoutFacet;
import org.apache.isis.core.metamodel.layout.MemberLayoutArranger;
import org.apache.isis.core.metamodel.layout.OrderSet;
import org.apache.isis.core.metamodel.spec.ObjectSpecification;
@@ -47,7 +50,18 @@ public class MemberLayoutArrangerUsingMemberOrderFacet implements MemberLayoutAr
LOG.debug("MemberLayoutArrangerUsingMemberOrderFacet: createAssociationOrderSetFor " + spec.getFullIdentifier());
}
- return DeweyOrderSet.createOrderSet(associationMethods);
+ final DeweyOrderSet orderSet = DeweyOrderSet.createOrderSet(associationMethods);
+ final MemberGroupLayoutFacet memberGroupLayoutFacet = spec.getFacet(MemberGroupLayoutFacet.class);
+
+ if(memberGroupLayoutFacet != null) {
+ final List<String> groupOrder = Lists.newArrayList();
+ groupOrder.addAll(memberGroupLayoutFacet.getLeft());
+ groupOrder.addAll(memberGroupLayoutFacet.getMiddle());
+ groupOrder.addAll(memberGroupLayoutFacet.getRight());
+
+ orderSet.reorderChildren(groupOrder);
+ }
+ return orderSet;
}
// ////////////////////////////////////////////////////////////////////////////
[2/2] git commit: ISIS-490: removing dependencies on common-logging
Posted by da...@apache.org.
ISIS-490: removing dependencies on common-logging
... where possible (used by some 3rd party dependencies, however)
Project: http://git-wip-us.apache.org/repos/asf/isis/repo
Commit: http://git-wip-us.apache.org/repos/asf/isis/commit/16854d35
Tree: http://git-wip-us.apache.org/repos/asf/isis/tree/16854d35
Diff: http://git-wip-us.apache.org/repos/asf/isis/diff/16854d35
Branch: refs/heads/master
Commit: 16854d353e58551de453df94215ce59bd7df5d31
Parents: 6ec4f41
Author: Dan Haywood <da...@apache.org>
Authored: Fri Aug 16 07:22:12 2013 +0100
Committer: Dan Haywood <da...@apache.org>
Committed: Fri Aug 16 07:22:12 2013 +0100
----------------------------------------------------------------------
.../objectstore/jdo/jdo-datanucleus/pom.xml | 6 +-
component/security/shiro/pom.xml | 2 +
component/viewer/restfulobjects/pom.xml | 9 ++
core/pom.xml | 5 -
.../src/main/webapp/WEB-INF/logging.properties | 103 +++++++++++++------
5 files changed, 86 insertions(+), 39 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/isis/blob/16854d35/component/objectstore/jdo/jdo-datanucleus/pom.xml
----------------------------------------------------------------------
diff --git a/component/objectstore/jdo/jdo-datanucleus/pom.xml b/component/objectstore/jdo/jdo-datanucleus/pom.xml
index 364d4b5..266baf4 100644
--- a/component/objectstore/jdo/jdo-datanucleus/pom.xml
+++ b/component/objectstore/jdo/jdo-datanucleus/pom.xml
@@ -111,7 +111,11 @@
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-log4j12</artifactId>
- <scope>test</scope>
+ </dependency>
+ <dependency>
+ <!-- because DataNucleus uses log4j as its preferred logger -->
+ <groupId>log4j</groupId>
+ <artifactId>log4j</artifactId>
</dependency>
<dependency>
http://git-wip-us.apache.org/repos/asf/isis/blob/16854d35/component/security/shiro/pom.xml
----------------------------------------------------------------------
diff --git a/component/security/shiro/pom.xml b/component/security/shiro/pom.xml
index 0a13f60..eb20458 100644
--- a/component/security/shiro/pom.xml
+++ b/component/security/shiro/pom.xml
@@ -122,11 +122,13 @@
<scope>test</scope>
</dependency>
+<!--
<dependency>
<groupId>commons-logging</groupId>
<artifactId>commons-logging</artifactId>
<scope>provided</scope>
</dependency>
+-->
<dependency>
<groupId>org.slf4j</groupId>
http://git-wip-us.apache.org/repos/asf/isis/blob/16854d35/component/viewer/restfulobjects/pom.xml
----------------------------------------------------------------------
diff --git a/component/viewer/restfulobjects/pom.xml b/component/viewer/restfulobjects/pom.xml
index 835393a..139879f 100644
--- a/component/viewer/restfulobjects/pom.xml
+++ b/component/viewer/restfulobjects/pom.xml
@@ -153,6 +153,15 @@
<scope>test</scope>
</dependency>
+ <dependency>
+ <!--
+ required because resteasy-jaxrs declares as a test dependency
+ whereas httpclient4 needs it as a compile dependency -->
+ <groupId>commons-logging</groupId>
+ <artifactId>commons-logging</artifactId>
+ <version>1.1.2</version>
+ </dependency>
+
</dependencies>
</dependencyManagement>
http://git-wip-us.apache.org/repos/asf/isis/blob/16854d35/core/pom.xml
----------------------------------------------------------------------
diff --git a/core/pom.xml b/core/pom.xml
index e263a75..c298e5c 100644
--- a/core/pom.xml
+++ b/core/pom.xml
@@ -1191,11 +1191,6 @@ ${license.additional-notes}
<version>2.6</version>
</dependency>
<dependency>
- <groupId>commons-logging</groupId>
- <artifactId>commons-logging</artifactId>
- <version>1.1.2</version>
- </dependency>
- <dependency>
<groupId>commons-collections</groupId>
<artifactId>commons-collections</artifactId>
<version>3.2.1</version>
http://git-wip-us.apache.org/repos/asf/isis/blob/16854d35/example/application/quickstart_wicket_restful_jdo/webapp/src/main/webapp/WEB-INF/logging.properties
----------------------------------------------------------------------
diff --git a/example/application/quickstart_wicket_restful_jdo/webapp/src/main/webapp/WEB-INF/logging.properties b/example/application/quickstart_wicket_restful_jdo/webapp/src/main/webapp/WEB-INF/logging.properties
index f9cbe50..a36d253 100644
--- a/example/application/quickstart_wicket_restful_jdo/webapp/src/main/webapp/WEB-INF/logging.properties
+++ b/example/application/quickstart_wicket_restful_jdo/webapp/src/main/webapp/WEB-INF/logging.properties
@@ -22,51 +22,20 @@
log4j.rootCategory=INFO, Console
#log4j.rootCategory=DEBUG, Console
+
# The console appender
log4j.appender.Console=org.apache.log4j.ConsoleAppender
log4j.appender.Console.target=System.out
log4j.appender.Console.layout=org.apache.log4j.PatternLayout
log4j.appender.Console.layout.ConversionPattern=%d{ABSOLUTE} [%-20c{1} %-10t %-5p] %m%n
+
log4j.appender.File=org.apache.log4j.RollingFileAppender
log4j.appender.File.file=isis.log
log4j.appender.File.append=false
log4j.appender.File.layout=org.apache.log4j.PatternLayout
log4j.appender.File.layout.ConversionPattern=%d [%-20c{1} %-10t %-5p] %m%n
-
-
-
-#log4j.logger.org.apache.isis.viewer.wicket.viewer.integration.wicket.WebRequestCycleForIsis=DEBUG, Console
-#log4j.additivity.org.apache.isis.viewer.wicket.viewer.integration.wicket.WebRequestCycleForIsis=false
-
-
-! turn on the internal log4j debugging flag so we can see what it is doing
-#log4j.debug=true
-
-
-log4j.logger.jdbc.sqlonly=DEBUG, sql, Console
-log4j.additivity.jdbc.sqlonly=false
-
-log4j.logger.jdbc.resultsettable=DEBUG, jdbc, Console
-log4j.additivity.jdbc.resultsettable=false
-
-
-
-log4j.logger.jdbc.audit=WARN,jdbc, Console
-log4j.additivity.jdbc.audit=false
-
-log4j.logger.jdbc.resultset=WARN,jdbc
-log4j.additivity.jdbc.resultset=false
-
-log4j.logger.jdbc.sqltiming=WARN,sqltiming
-log4j.additivity.jdbc.sqltiming=false
-
-log4j.logger.jdbc.connection=FATAL,connection
-log4j.additivity.jdbc.connection=false
-
-
-
log4j.appender.sql=org.apache.log4j.FileAppender
log4j.appender.sql.File=./logs/sql.log
log4j.appender.sql.Append=false
@@ -91,3 +60,71 @@ log4j.appender.connection.Append=false
log4j.appender.connection.layout=org.apache.log4j.PatternLayout
log4j.appender.connection.layout.ConversionPattern=%d{yyyy-MM-dd HH:mm:ss.SSS} %m%n
+
+
+
+
+! turn on the internal log4j debugging flag so we can see what it is doing
+#log4j.debug=true
+
+
+# DataNucleus
+log4j.logger.DataNucleus.Datastore.Native=DEBUG, Console
+log4j.logger.DataNucleus.Datastore.Schema=DEBUG, Console
+
+log4j.logger.DataNucleus.Persistence=WARN, Console
+log4j.logger.DataNucleus.Transaction=WARN, Console
+log4j.logger.DataNucleus.Connection=WARN, Console
+log4j.logger.DataNucleus.Query=WARN, Console
+log4j.logger.DataNucleus.Cache=WARN, Console
+log4j.logger.DataNucleus.MetaData=WARN, Console
+log4j.logger.DataNucleus.Datastore=WARN, Console
+log4j.logger.DataNucleus.Datastore.Persist=WARN, Console
+log4j.logger.DataNucleus.Datastore.Retrieve=WARN, Console
+log4j.logger.DataNucleus.General=WARN, Console
+log4j.logger.DataNucleus.Lifecycle=WARN, Console
+log4j.logger.DataNucleus.ValueGeneration=WARN, Console
+log4j.logger.DataNucleus.Enhancer=WARN, Console
+log4j.logger.DataNucleus.SchemaTool=ERROR, Console
+log4j.logger.DataNucleus.JDO=WARN, Console
+log4j.logger.DataNucleus.JPA=ERROR, Console
+log4j.logger.DataNucleus.JCA=WARN, Console
+log4j.logger.DataNucleus.IDE=ERROR, Console
+
+
+# if using log4jdbc-remix as JDBC driver
+#log4j.logger.jdbc.sqlonly=DEBUG, sql, Console
+#log4j.additivity.jdbc.sqlonly=false
+#log4j.logger.jdbc.resultsettable=DEBUG, jdbc, Console
+#log4j.additivity.jdbc.resultsettable=false
+
+#log4j.logger.jdbc.audit=WARN,jdbc, Console
+#log4j.additivity.jdbc.audit=false
+#log4j.logger.jdbc.resultset=WARN,jdbc
+#log4j.additivity.jdbc.resultset=false
+#log4j.logger.jdbc.sqltiming=WARN,sqltiming
+#log4j.additivity.jdbc.sqltiming=false
+#log4j.logger.jdbc.connection=FATAL,connection
+#log4j.additivity.jdbc.connection=false
+
+
+
+# track Isis/JDO lifecycle integration
+
+#log4j.logger.org.apache.isis.runtimes.dflt.objectstores.jdo.datanucleus.persistence.FrameworkSynchronizer=DEBUG, Console
+#log4j.additivity.org.apache.isis.runtimes.dflt.objectstores.jdo.datanucleus.persistence.FrameworkSynchronizer=false
+
+#log4j.logger.org.apache.isis.objectstore.jdo.datanucleus.persistence.IsisLifecycleListener=DEBUG,Console
+#log4j.additivity.org.apache.isis.objectstore.jdo.datanucleus.persistence.IsisLifecycleListener=false
+
+
+
+
+# track Isis/Wicket lifecycle integration
+
+#log4j.logger.org.apache.isis.viewer.wicket.viewer.integration.wicket.WebRequestCycleForIsis=DEBUG, Console
+#log4j.additivity.org.apache.isis.viewer.wicket.viewer.integration.wicket.WebRequestCycleForIsis=false
+
+#log4j.logger.org.apache.isis.viewer.wicket.viewer.integration.isis.IsisContextForWicket=INFO,Console
+#log4j.additivity.org.apache.isis.viewer.wicket.viewer.integration.isis.IsisContextForWicket=false
+