You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Jens Geyer (Jira)" <ji...@apache.org> on 2019/11/25 21:30:00 UTC
[jira] [Comment Edited] (THRIFT-5032) Allows PascalCase properties
for netstd
[ https://issues.apache.org/jira/browse/THRIFT-5032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981903#comment-16981903 ]
Jens Geyer edited comment on THRIFT-5032 at 11/25/19 9:29 PM:
--------------------------------------------------------------
Make it the default. We don't need an option for this. The wire format is compatible, maybe some code must be changed. But with the port to netstd30 this is required anyway.
was (Author: jensg):
Make it the default. We don't need an option for this.
> Allows PascalCase properties for netstd
> ---------------------------------------
>
> Key: THRIFT-5032
> URL: https://issues.apache.org/jira/browse/THRIFT-5032
> Project: Thrift
> Issue Type: Improvement
> Reporter: Paulo Neves
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Microsoft guidelines state that public properties should be PascalCase. Currently if a property in the thrift description is MyProperty it will be expanded into My_property which is clearly wrong. As this is a breaking change I added a pascal option to the netstd generator. I believe that in the future this should be the default and the old style deprecated.
> I also added the option to the generator of the Server test, so that we can have a test with the properties in PascalCase talking with a netstd client without PascalCase. I hope this is ok.
>
> https://docs.microsoft.com/en-us/dotnet/standard/design-guidelines/capitalization-conventions
--
This message was sent by Atlassian Jira
(v8.3.4#803005)