You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/08/03 05:04:41 UTC
[GitHub] [pulsar] codelipenghui opened a new pull request #7724: Close the previous reader of the health check topic
codelipenghui opened a new pull request #7724:
URL: https://github.com/apache/pulsar/pull/7724
### Modifications
Close the previous reader of the health check topic. Not sure what caused the reader to not close properly, this PR tries to delete the previous reader of the health check to make sure the previous readers can be closed.
If the previous reader can't be closed, the backlog of the health check topic will keep increasing. According to the broker heap dump, there is more than one reader can't be closed.
This PR is related to #7589
### Verifying this change
The problem is hard to reproduce.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
- Does this pull request introduce a new feature? (no)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wolfstudy commented on pull request #7724: Close the previous reader of the health check topic
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #7724:
URL: https://github.com/apache/pulsar/pull/7724#issuecomment-668364071
> @wolfstudy to help cherry-pick to both branch-2.5 and branch-2.6
Sure, already cherry-pick the pull request to branch-2.5 and branch-2.6
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #7724: Close the previous reader of the health check topic
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #7724:
URL: https://github.com/apache/pulsar/pull/7724
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #7724: Close the previous reader of the health check topic
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #7724:
URL: https://github.com/apache/pulsar/pull/7724#issuecomment-668359720
@wolfstudy to help cherry-pick to both branch-2.5 and branch-2.6
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org