You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "versha890 (via GitHub)" <gi...@apache.org> on 2025/12/13 09:12:44 UTC
[PR] Firbug/1313 [airflow-site]
versha890 opened a new pull request, #1319:
URL: https://github.com/apache/airflow-site/pull/1319
- Only highlight "Airflow Survey 2024" nav item when visiting the survey page.
- Fixes double highlight issue in navigation bar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix double navigation highlight on Airflow Survey 2024 page [airflow-site]
Posted by "versha890 (via GitHub)" <gi...@apache.org>.
versha890 closed pull request #1319: Fix double navigation highlight on Airflow Survey 2024 page
URL: https://github.com/apache/airflow-site/pull/1319
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Firbug/1313 [airflow-site]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #1319:
URL: https://github.com/apache/airflow-site/pull/1319#issuecomment-3649183053
Can you please update the title to be meaningful - and possibly add screenshots?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix double navigation highlight on Airflow Survey 2024 page [airflow-site]
Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 commented on code in PR #1319:
URL: https://github.com/apache/airflow-site/pull/1319#discussion_r2616803965
##########
landing-pages/site/content/en/blog/airflow-survey-2024/index.md:
##########
@@ -12,6 +12,6 @@ menu:
weight: 31
---
-
+
Review Comment:
this space is not necessary
##########
landing-pages/site/layouts/partials/navbar.html:
##########
@@ -51,7 +51,17 @@
{{ $menusLen := len .Site.Menus.main }}
<div class="navbar__links-container">
{{ range $index, $el := .Site.Menus.main }}
- {{ $active := or ($p.IsMenuCurrent "main" $el) ($p.HasMenuCurrent "main" $el) }}
+ {{ $active := false }}
+{{ with $el.Page }}
+ {{ if eq $.RelPermalink .RelPermalink }}
+ {{ $active = true }}
+ {{ else }}
+ {{ $active = or ($p.IsMenuCurrent "main" $el) ($p.HasMenuCurrent "main" $el) }}
+ {{ end }}
+{{ else }}
+ {{ $active = or ($p.IsMenuCurrent "main" $el) ($p.HasMenuCurrent "main" $el) }}
+{{ end }}
+
Review Comment:
I’m not convinced that this code addresses the problem you’re trying to solve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix double navigation highlight on Airflow Survey 2024 page [airflow-site]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #1319:
URL: https://github.com/apache/airflow-site/pull/1319#issuecomment-3650392472
Still - there are some unrelated changes about pager that reverts your earlier change . Can you please review your PR before we do - it becomes annoying and takes far too much of our time to review those changes.
Maybe you should learn how to use git and not rely on what your AI is doing but spend a bit of itme on reviewing the change befor submittting it - it's really annoying that other people has to review all the changes that your agent does and you do no check on it at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix double navigation highlight on Airflow Survey 2024 page [airflow-site]
Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 commented on PR #1319:
URL: https://github.com/apache/airflow-site/pull/1319#issuecomment-3650422946
As @potiuk mentioned, there are still some unnecessary changes that I previously pointed out.
Could you please revert those changes and share a screenshot showing that it works as expected?
Alternatively, you’re welcome to review your own code once more, take some time to learn from it, and then submit a new PR 😉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix double navigation highlight on Airflow Survey 2024 page [airflow-site]
Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 commented on code in PR #1319:
URL: https://github.com/apache/airflow-site/pull/1319#discussion_r2616431471
##########
landing-pages/site/layouts/partials/pager.html:
##########
Review Comment:
this
##########
landing-pages/site/content/en/blog/airflow-survey-2024/index.md:
##########
Review Comment:
this
##########
test-site/layouts/partials/navbar.html:
##########
Review Comment:
this
##########
test-site/hugo.toml:
##########
Review Comment:
this
##########
test-site/archetypes/default.md:
##########
Review Comment:
this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix double navigation highlight on Airflow Survey 2024 page [airflow-site]
Posted by "versha890 (via GitHub)" <gi...@apache.org>.
versha890 commented on PR #1319:
URL: https://github.com/apache/airflow-site/pull/1319#issuecomment-3650340017
I’ve cleaned up the code by removing unnecessary changes and have fixed the bug. Please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix double navigation highlight on Airflow Survey 2024 page [airflow-site]
Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 commented on PR #1319:
URL: https://github.com/apache/airflow-site/pull/1319#issuecomment-3650442730
<img width="2168" height="1397" alt="image" src="https://github.com/user-attachments/assets/bc14037f-1dbf-4c8a-ace7-a6876a428d13" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix double navigation highlight on Airflow Survey 2024 page [airflow-site]
Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 commented on PR #1319:
URL: https://github.com/apache/airflow-site/pull/1319#issuecomment-3649654006
it seems that commits from a previous PR(#1314 ) are included.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org