[GitHub] [helix] narendly commented on a change in pull request #608: Stabilize the TestAlertingRebalancerFailure test

[GitBox <gi...@apache.org>]

narendly commented on a change in pull request #608: Stabilize the TestAlertingRebalancerFailure test
URL: https://github.com/apache/helix/pull/608#discussion_r347113423
 
 

 ##########
 File path: helix-core/src/test/java/org/apache/helix/integration/TestAlertingRebalancerFailure.java
 ##########
 @@ -164,6 +164,7 @@ public void testTagSetIncorrect() throws Exception {
         BuiltInStateModelDefinitions.MasterSlave.name(), RebalanceMode.FULL_AUTO.name());
     ZkHelixClusterVerifier verifier = new BestPossibleExternalViewVerifier.Builder(CLUSTER_NAME)
         .setZkAddr(ZK_ADDR).setResources(new HashSet<>(Collections.singleton(testDb))).build();
+    _gSetupTool.getClusterManagementTool().rebalance(CLUSTER_NAME, testDb, 3);
 
 Review comment:
   @alirezazamani 
   I see that this was marked as resolved but still see 3, not _replica. Has this PR been updated? I see your comment stating that this PR is ready to be merged. Is there something amiss here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org