You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2019/12/11 13:32:49 UTC

[GitHub] [zookeeper] ravowlga123 commented on a change in pull request #1171: ZOOKEEPER-2083 Remove deprecated class AuthFastLeaderElection

ravowlga123 commented on a change in pull request #1171: ZOOKEEPER-2083 Remove deprecated class AuthFastLeaderElection
URL: https://github.com/apache/zookeeper/pull/1171#discussion_r356599317
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java
 ##########
 @@ -1226,12 +1226,6 @@ protected Election createElectionAlgorithm(int electionAlgorithm) {
 
         //TODO: use a factory rather than a switch
         switch (electionAlgorithm) {
 
 Review comment:
   Hey @maoling I have made addressed your comments and please do let me know if you see any additional changes that are required.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services