You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@activemq.apache.org by "Timothy Bish (Resolved) (JIRA)" <ji...@apache.org> on 2012/02/06 23:56:59 UTC

[jira] [Resolved] (AMQ-3703) Replace use of class Valve with standard JDK ReentrantReadWriteLock in class Topic.java

     [ https://issues.apache.org/jira/browse/AMQ-3703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Timothy Bish resolved AMQ-3703.
-------------------------------

    Resolution: Fixed

Fix applied in trunk.
                
> Replace use of class Valve with standard JDK ReentrantReadWriteLock in class Topic.java
> ---------------------------------------------------------------------------------------
>
>                 Key: AMQ-3703
>                 URL: https://issues.apache.org/jira/browse/AMQ-3703
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 5.5.1
>            Reporter: Timothy Bish
>            Assignee: Timothy Bish
>            Priority: Trivial
>             Fix For: 5.6.0
>
>
> The Topic class uses an old AMQ class Valve that is essentially a pre JDK 1.5 Read / Write lock.  The JDK RW lock is much more efficient than ours using only a single CAS operation in many cases when multiple readers need access to the lock as opposed to the Valve class that requires all threads to synchronize and possibly wait on a monitor.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira