You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by "Ben Speakmon (JIRA)" <ji...@apache.org> on 2007/02/07 21:45:05 UTC
[jira] Created: (EMAIL-62) Ant patch to enforce source 1.4 and
target 1.4 when compiling
Ant patch to enforce source 1.4 and target 1.4 when compiling
-------------------------------------------------------------
Key: EMAIL-62
URL: https://issues.apache.org/jira/browse/EMAIL-62
Project: Commons Email
Issue Type: Bug
Affects Versions: 1.1
Reporter: Ben Speakmon
Fix For: 1.1
Attachments: build.xml.patch
Suppresses spurious 1.5 type safety warnings when building commons-email on JDK >= 1.5. Attaching patch shortly...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Commented: (EMAIL-62) [email] Build patches to enforce
source 1.4 and target 1.4 when compiling
Posted by "Ben Speakmon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/EMAIL-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472839 ]
Ben Speakmon commented on EMAIL-62:
-----------------------------------
I'm with Dion 100% on meeting the needs of users, but as I said on the list, I consider the benefits of using 1.4 -- allowing us to use the latest javamail/activation versions, much better charset support, etc. -- outweigh the new dependencies. It's better than asking users to stick with the known bugs of javamail 1.3.1 and being forced to reimplement the charset code in 1.3 when the majority of people using it are on at least 1.4.
It's not my project, though, and if 1.4 is unacceptable for some other reason, we'll think of something clever. As Piero says, the important thing is to get fixes out for what's not working.
> [email] Build patches to enforce source 1.4 and target 1.4 when compiling
> -------------------------------------------------------------------------
>
> Key: EMAIL-62
> URL: https://issues.apache.org/jira/browse/EMAIL-62
> Project: Commons Email
> Issue Type: Bug
> Affects Versions: 1.1
> Reporter: Ben Speakmon
> Fix For: 1.1
>
> Attachments: build.xml.patch, project.properties, project.properties.patch
>
>
> Maven and Ant patches. Ant patch suppresses spurious 1.5 type safety warnings when building commons-email on JDK >= 1.5.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Resolved: (EMAIL-62) [email] Build patches to enforce source
1.4 and target 1.4 when compiling
Posted by "dion gillard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/EMAIL-62?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dion gillard resolved EMAIL-62.
-------------------------------
Resolution: Fixed
Patches applied - thanks guys!
> [email] Build patches to enforce source 1.4 and target 1.4 when compiling
> -------------------------------------------------------------------------
>
> Key: EMAIL-62
> URL: https://issues.apache.org/jira/browse/EMAIL-62
> Project: Commons Email
> Issue Type: Bug
> Affects Versions: 1.1
> Reporter: Ben Speakmon
> Fix For: 1.1
>
> Attachments: build.xml.patch, project.properties, project.properties.patch
>
>
> Maven and Ant patches. Ant patch suppresses spurious 1.5 type safety warnings when building commons-email on JDK >= 1.5.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Updated: (EMAIL-62) Ant patch to enforce source 1.4 and
target 1.4 when compiling
Posted by "Ben Speakmon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/EMAIL-62?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ben Speakmon updated EMAIL-62:
------------------------------
Attachment: build.xml.patch
> Ant patch to enforce source 1.4 and target 1.4 when compiling
> -------------------------------------------------------------
>
> Key: EMAIL-62
> URL: https://issues.apache.org/jira/browse/EMAIL-62
> Project: Commons Email
> Issue Type: Bug
> Affects Versions: 1.1
> Reporter: Ben Speakmon
> Fix For: 1.1
>
> Attachments: build.xml.patch
>
>
> Suppresses spurious 1.5 type safety warnings when building commons-email on JDK >= 1.5. Attaching patch shortly...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Updated: (EMAIL-62) [email] Build patches to enforce source
1.4 and target 1.4 when compiling
Posted by "Ben Speakmon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/EMAIL-62?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ben Speakmon updated EMAIL-62:
------------------------------
Description: Maven and Ant patches. Ant patch suppresses spurious 1.5 type safety warnings when building commons-email on JDK >= 1.5. (was: Suppresses spurious 1.5 type safety warnings when building commons-email on JDK >= 1.5. Attaching patch shortly...)
Summary: [email] Build patches to enforce source 1.4 and target 1.4 when compiling (was: Build patches to enforce source 1.4 and target 1.4 when compiling)
> [email] Build patches to enforce source 1.4 and target 1.4 when compiling
> -------------------------------------------------------------------------
>
> Key: EMAIL-62
> URL: https://issues.apache.org/jira/browse/EMAIL-62
> Project: Commons Email
> Issue Type: Bug
> Affects Versions: 1.1
> Reporter: Ben Speakmon
> Fix For: 1.1
>
> Attachments: build.xml.patch, project.properties, project.properties.patch
>
>
> Maven and Ant patches. Ant patch suppresses spurious 1.5 type safety warnings when building commons-email on JDK >= 1.5.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Commented: (EMAIL-62) [email] Build patches to enforce
source 1.4 and target 1.4 when compiling
Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/EMAIL-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12474625 ]
Henri Yandell commented on EMAIL-62:
------------------------------------
It doesn't seem to get included. I changed the project.properties to 1.4 target, and ran maven ant. There's no occurrence of 1.4 or maven.compile.source in the build.xml.
Personally - I think the build.xml should be removed, it only has value when we were trying to build 1.3 specific builds.
> [email] Build patches to enforce source 1.4 and target 1.4 when compiling
> -------------------------------------------------------------------------
>
> Key: EMAIL-62
> URL: https://issues.apache.org/jira/browse/EMAIL-62
> Project: Commons Email
> Issue Type: Bug
> Affects Versions: 1.1
> Reporter: Ben Speakmon
> Fix For: 1.1
>
> Attachments: build.xml.patch, project.properties, project.properties.patch
>
>
> Maven and Ant patches. Ant patch suppresses spurious 1.5 type safety warnings when building commons-email on JDK >= 1.5.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Commented: (EMAIL-62) [email] Build patches to enforce
source 1.4 and target 1.4 when compiling
Posted by "Ben Speakmon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/EMAIL-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472996 ]
Ben Speakmon commented on EMAIL-62:
-----------------------------------
I didn't know how to generate a build.xml from maven at the time. I have no idea if it would work given a correct project (or pom).
I have zero objection to regenerating it.
> [email] Build patches to enforce source 1.4 and target 1.4 when compiling
> -------------------------------------------------------------------------
>
> Key: EMAIL-62
> URL: https://issues.apache.org/jira/browse/EMAIL-62
> Project: Commons Email
> Issue Type: Bug
> Affects Versions: 1.1
> Reporter: Ben Speakmon
> Fix For: 1.1
>
> Attachments: build.xml.patch, project.properties, project.properties.patch
>
>
> Maven and Ant patches. Ant patch suppresses spurious 1.5 type safety warnings when building commons-email on JDK >= 1.5.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Commented: (EMAIL-62) [email] Build patches to enforce
source 1.4 and target 1.4 when compiling
Posted by "Piero Ottuzzi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/EMAIL-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472592 ]
Piero Ottuzzi commented on EMAIL-62:
------------------------------------
Hi Dion, all,
commons-email 1.0 is quite broken and I think we need to move forward and release something working: the actual version has many problems and holding on a release for a JDK1.3 compatibility it seems overkill to me.
Just my idea...
Bye
Piero
> [email] Build patches to enforce source 1.4 and target 1.4 when compiling
> -------------------------------------------------------------------------
>
> Key: EMAIL-62
> URL: https://issues.apache.org/jira/browse/EMAIL-62
> Project: Commons Email
> Issue Type: Bug
> Affects Versions: 1.1
> Reporter: Ben Speakmon
> Fix For: 1.1
>
> Attachments: build.xml.patch, project.properties, project.properties.patch
>
>
> Maven and Ant patches. Ant patch suppresses spurious 1.5 type safety warnings when building commons-email on JDK >= 1.5.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Updated: (EMAIL-62) Build patches to enforce source 1.4 and
target 1.4 when compiling
Posted by "Ben Speakmon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/EMAIL-62?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ben Speakmon updated EMAIL-62:
------------------------------
Attachment: project.properties.patch
Oops. Maybe I'll attach the patch instead of the whole file. :)
> Build patches to enforce source 1.4 and target 1.4 when compiling
> -----------------------------------------------------------------
>
> Key: EMAIL-62
> URL: https://issues.apache.org/jira/browse/EMAIL-62
> Project: Commons Email
> Issue Type: Bug
> Affects Versions: 1.1
> Reporter: Ben Speakmon
> Fix For: 1.1
>
> Attachments: build.xml.patch, project.properties, project.properties.patch
>
>
> Suppresses spurious 1.5 type safety warnings when building commons-email on JDK >= 1.5. Attaching patch shortly...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Commented: (EMAIL-62) [email] Build patches to enforce
source 1.4 and target 1.4 when compiling
Posted by "dion gillard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/EMAIL-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472428 ]
dion gillard commented on EMAIL-62:
-----------------------------------
So this means that commons-email is now JDK 1.4+.
Has anyone surveyed the users and seen if we still have any on 1.3 that can't stay on email 1.0?
> [email] Build patches to enforce source 1.4 and target 1.4 when compiling
> -------------------------------------------------------------------------
>
> Key: EMAIL-62
> URL: https://issues.apache.org/jira/browse/EMAIL-62
> Project: Commons Email
> Issue Type: Bug
> Affects Versions: 1.1
> Reporter: Ben Speakmon
> Fix For: 1.1
>
> Attachments: build.xml.patch, project.properties, project.properties.patch
>
>
> Maven and Ant patches. Ant patch suppresses spurious 1.5 type safety warnings when building commons-email on JDK >= 1.5.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Updated: (EMAIL-62) Build patches to enforce source 1.4 and
target 1.4 when compiling
Posted by "Ben Speakmon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/EMAIL-62?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ben Speakmon updated EMAIL-62:
------------------------------
Summary: Build patches to enforce source 1.4 and target 1.4 when compiling (was: Ant patch to enforce source 1.4 and target 1.4 when compiling)
Changing summary since I'm about to attach another patch to enforce 1.4 source/target in the Maven build...
> Build patches to enforce source 1.4 and target 1.4 when compiling
> -----------------------------------------------------------------
>
> Key: EMAIL-62
> URL: https://issues.apache.org/jira/browse/EMAIL-62
> Project: Commons Email
> Issue Type: Bug
> Affects Versions: 1.1
> Reporter: Ben Speakmon
> Fix For: 1.1
>
> Attachments: build.xml.patch, project.properties, project.properties.patch
>
>
> Suppresses spurious 1.5 type safety warnings when building commons-email on JDK >= 1.5. Attaching patch shortly...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Updated: (EMAIL-62) Build patches to enforce source 1.4 and
target 1.4 when compiling
Posted by "Ben Speakmon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/EMAIL-62?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ben Speakmon updated EMAIL-62:
------------------------------
Attachment: project.properties
> Build patches to enforce source 1.4 and target 1.4 when compiling
> -----------------------------------------------------------------
>
> Key: EMAIL-62
> URL: https://issues.apache.org/jira/browse/EMAIL-62
> Project: Commons Email
> Issue Type: Bug
> Affects Versions: 1.1
> Reporter: Ben Speakmon
> Fix For: 1.1
>
> Attachments: build.xml.patch, project.properties, project.properties.patch
>
>
> Suppresses spurious 1.5 type safety warnings when building commons-email on JDK >= 1.5. Attaching patch shortly...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Commented: (EMAIL-62) [email] Build patches to enforce
source 1.4 and target 1.4 when compiling
Posted by "dion gillard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/EMAIL-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472986 ]
dion gillard commented on EMAIL-62:
-----------------------------------
Does anyone know why we're patching a Maven-generated build.xml file instead of just regenerating it?
Doesn't the maven ant plugin generate a build file with the correct javac task attributes?
> [email] Build patches to enforce source 1.4 and target 1.4 when compiling
> -------------------------------------------------------------------------
>
> Key: EMAIL-62
> URL: https://issues.apache.org/jira/browse/EMAIL-62
> Project: Commons Email
> Issue Type: Bug
> Affects Versions: 1.1
> Reporter: Ben Speakmon
> Fix For: 1.1
>
> Attachments: build.xml.patch, project.properties, project.properties.patch
>
>
> Maven and Ant patches. Ant patch suppresses spurious 1.5 type safety warnings when building commons-email on JDK >= 1.5.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org