svn commit: r1440933 - /lucene/dev/branches/lucene4547/lucene/core/src/java/org/apache/lucene/index/DocValuesProcessor.java

[rm...@apache.org]

Author: rmuir
Date: Thu Jan 31 12:40:03 2013
New Revision: 1440933

URL: http://svn.apache.org/viewvc?rev=1440933&view=rev
Log:
clear nocommits

Modified:
    lucene/dev/branches/lucene4547/lucene/core/src/java/org/apache/lucene/index/DocValuesProcessor.java

Modified: lucene/dev/branches/lucene4547/lucene/core/src/java/org/apache/lucene/index/DocValuesProcessor.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/lucene4547/lucene/core/src/java/org/apache/lucene/index/DocValuesProcessor.java?rev=1440933&r1=1440932&r2=1440933&view=diff
==============================================================================
--- lucene/dev/branches/lucene4547/lucene/core/src/java/org/apache/lucene/index/DocValuesProcessor.java (original)
+++ lucene/dev/branches/lucene4547/lucene/core/src/java/org/apache/lucene/index/DocValuesProcessor.java Thu Jan 31 12:40:03 2013
@@ -46,13 +46,10 @@ final class DocValuesProcessor extends S
 
   @Override
   void finishDocument() {
-    // nocommit catch missing DV fields here?  else we have
-    // null/"" depending on how docs landed in segments?
   }
 
   @Override
   public void addField(int docID, StorableField field, FieldInfo fieldInfo) {
-    // nocommit: these checks are duplicated everywhere
     final DocValuesType dvType = field.fieldType().docValueType();
     if (dvType != null) {
       fieldInfo.setDocValuesType(dvType);
@@ -82,6 +79,10 @@ final class DocValuesProcessor extends S
           writer.finish(state.segmentInfo.getDocCount());
           writer.flush(state, dvConsumer);
         }
+        // TODO: catch missing DV fields here?  else we have
+        // null/"" depending on how docs landed in segments?
+        // but we can't detect all cases, and we should leave
+        // this behavior undefined. dv is not "schemaless": its column-stride.
         writers.clear();
         success = true;
       } finally {