[GitHub] [spark] andygrove commented on a diff in pull request #42434: [WIP][SPARK-43063][SQL][FOLLOWUP] Add a space between -> and value when first value is null

["andygrove (via GitHub)" <gi...@apache.org>]

andygrove commented on code in PR #42434:
URL: https://github.com/apache/spark/pull/42434#discussion_r1290421968


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ToStringBase.scala:
##########
@@ -352,7 +352,7 @@ trait ToStringBase { self: UnaryExpression with TimeZoneAwareExpression =>
        |  $buffer.append($keyToStringFunc($getMapFirstKey));
        |  $buffer.append(" ->");
        |  if ($map.valueArray().isNullAt(0)) {
-       |    ${appendNull(buffer, isFirstElement = true)}
+       |    ${appendNull(buffer, isFirstElement = false)}

Review Comment:
   There should always be a space after `->` and before the value. It does not matter if this is the first key-value pair or not.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org