You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by "arshadmohammad (via GitHub)" <gi...@apache.org> on 2023/10/27 18:57:41 UTC
[PR] BIGTOP-4034: Add python3 support in bigtop-select [bigtop]
arshadmohammad opened a new pull request, #1203:
URL: https://github.com/apache/bigtop/pull/1203
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/BIGTOP/How+to+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g., 'BIGTOP-3638: Your PR title ...'.
-->
### Description of PR
Added python3 support in bigtop-select
### How was this patch tested?
Applied changes on already installed ambari hadoop cluster
executed below commands, all got executed successfully
```
ambari-python-wrap /usr/lib/bigtop-select/distro-select versions
ambari-python-wrap /usr/lib/bigtop-select/distro-select packages
ambari-python-wrap /usr/lib/bigtop-select/distro-select status
```
### For code changes:
- [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'BIGTOP-3638. Your PR title ...')?
- [ ] Make sure that newly added files do not have any licensing issues. When in doubt refer to https://www.apache.org/licenses/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] BIGTOP-4034: Add python3 support in bigtop-select [bigtop]
Posted by "sekikn (via GitHub)" <gi...@apache.org>.
sekikn commented on PR #1203:
URL: https://github.com/apache/bigtop/pull/1203#issuecomment-1784468278
Thank you for your contribution, @arshadmohammad. Building RPM succeeded with your PR.
```
$ curl -sL https://github.com/apache/bigtop/pull/1203.diff | git apply
$ ./gradlew bigtop-select-clean bigtop-select-pkg repo
...
BUILD SUCCESSFUL in 9s
```
But after that, running `*-select` failed due to the lack of python3.
```
$ ./docker-hadoop.sh -d -dcp -C config_centos-7.yaml -G -L -k bigtop-utils -c 1
$ ./docker-hadoop.sh -dcp -e 1 bash
# yum install -y bigtop-select
...
Complete!
# /usr/lib/bigtop-select/conf-select
/usr/bin/env: python3: No such file or directory
# /usr/lib/bigtop-select/distro-select
/usr/bin/env: python3: No such file or directory
```
We should add a dependency on python3 to bigtop-select's spec file. Would you do that referring to other spec files such as Phoenix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] BIGTOP-4034: Add python3 support in bigtop-select [bigtop]
Posted by "timyuer (via GitHub)" <gi...@apache.org>.
timyuer commented on PR #1203:
URL: https://github.com/apache/bigtop/pull/1203#issuecomment-2073917493
@arshadmohammad
Hello, if you really don't have time, I can accept this PR in a week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] BIGTOP-4034: Add python3 support in bigtop-select [bigtop]
Posted by "JiaLiangC (via GitHub)" <gi...@apache.org>.
JiaLiangC commented on PR #1203:
URL: https://github.com/apache/bigtop/pull/1203#issuecomment-2068414407
@arshadmohammad It seems you haven't taken action on the review for several months. Do you still want to continue with this PR? If you don't have time to continue maintaining it, you can close it for now, to ensure that this matter can continue to move forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org