[GitHub] [flink] sunjincheng121 commented on a change in pull request #8550: [FLINK-12401][table] Support incremental emit under AccRetract mode for non-window streaming FlatAggregate on Table API

[GitBox <gi...@apache.org>]

sunjincheng121 commented on a change in pull request #8550: [FLINK-12401][table] Support incremental emit under AccRetract mode for non-window streaming FlatAggregate on Table API
URL: https://github.com/apache/flink/pull/8550#discussion_r292820153
 
 

 ##########
 File path: docs/dev/table/tableApi.md
 ##########
 @@ -2882,13 +2922,13 @@ val result = orders
       <td>
         <p>Groups and aggregates a table on a <a href="#group-windows">group window</a> and possibly one or more grouping keys. You have to close the "flatAggregate" with a select statement. And the select statement does not support aggregate functions.</p>
 {% highlight scala %}
-val tableAggFunc = new MyMinMax
+val top2 = new Top2()
 
 Review comment:
   `Top2()` -> `Top2` is enough for scala. But I am fine if want keeps the current style.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services