You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@stdcxx.apache.org by vi...@apache.org on 2008/04/19 02:10:38 UTC

svn commit: r649727 - /stdcxx/branches/4.2.x/include/rw/_config.h

Author: vitek
Date: Fri Apr 18 17:10:23 2008
New Revision: 649727

URL: http://svn.apache.org/viewvc?rev=649727&view=rev
Log:
2008-04-18  Travis Vitek  <vi...@roguewave.com>

	* include/rw/_config.h: Update _RWSTD_VER macro
	to correctly reflect the library version.


Modified:
    stdcxx/branches/4.2.x/include/rw/_config.h

Modified: stdcxx/branches/4.2.x/include/rw/_config.h
URL: http://svn.apache.org/viewvc/stdcxx/branches/4.2.x/include/rw/_config.h?rev=649727&r1=649726&r2=649727&view=diff
==============================================================================
--- stdcxx/branches/4.2.x/include/rw/_config.h (original)
+++ stdcxx/branches/4.2.x/include/rw/_config.h Fri Apr 18 17:10:23 2008
@@ -37,7 +37,7 @@
 
 /*** library version numbers and ids **************************************/
 
-#define _RWSTD_VER 0x04020001
+#define _RWSTD_VER 0x04020100
 //                    | | | |
 //                   MMmmuupp
 //                    | | | |



Re: svn commit: r649727 - /stdcxx/branches/4.2.x/include/rw/_config.h

Posted by Martin Sebor <se...@roguewave.com>.
Eric Lemings wrote:
>  
> 
>> -----Original Message-----
>> From: Martin Sebor [mailto:msebor@gmail.com] On Behalf Of Martin Sebor
>> Sent: Saturday, April 19, 2008 3:33 PM
>> To: dev@stdcxx.apache.org
>> Subject: Re: svn commit: r649727 - 
>> /stdcxx/branches/4.2.x/include/rw/_config.h
>>
>> vitek@apache.org wrote:
>>> Author: vitek
>>> Date: Fri Apr 18 17:10:23 2008
>>> New Revision: 649727
>>>
>>> URL: http://svn.apache.org/viewvc?rev=649727&view=rev
>>> Log:
>>> 2008-04-18  Travis Vitek  <vi...@roguewave.com>
>>>
>>> 	* include/rw/_config.h: Update _RWSTD_VER macro
>>> 	to correctly reflect the library version.
>> We discussed automating this once before but didn't make a decision:
>> http://stdcxx.markmail.org/message/bso6dno3fzm64pfa. I think we ought
>> to give some more thought to automating it so I created an enhancement
>> request to remind us: http://issues.apache.org/jira/browse/STDCXX-887.
> 
> In GNU-style distributions, it's updated in only one place -- in the
> configure.in or configure.ac file and propagated from there to other
> files.  Still requires a manual edit but at least in only one place
> to reduce maintenance.  I don't see how it can be done automatically.

We also update it in just one place: include/rw/_config.h,
but as Travis' patch demonstrates, it can be error prone.
One idea for automating it that Mark brought up in the
thread above was to let the top level GNUakefile extract
it from the value the $HeadURL$ Subversion keyword.

Martin

RE: svn commit: r649727 - /stdcxx/branches/4.2.x/include/rw/_config.h

Posted by Eric Lemings <Er...@roguewave.com>.
 

> -----Original Message-----
> From: Martin Sebor [mailto:msebor@gmail.com] On Behalf Of Martin Sebor
> Sent: Saturday, April 19, 2008 3:33 PM
> To: dev@stdcxx.apache.org
> Subject: Re: svn commit: r649727 - 
> /stdcxx/branches/4.2.x/include/rw/_config.h
> 
> vitek@apache.org wrote:
> > Author: vitek
> > Date: Fri Apr 18 17:10:23 2008
> > New Revision: 649727
> > 
> > URL: http://svn.apache.org/viewvc?rev=649727&view=rev
> > Log:
> > 2008-04-18  Travis Vitek  <vi...@roguewave.com>
> > 
> > 	* include/rw/_config.h: Update _RWSTD_VER macro
> > 	to correctly reflect the library version.
> 
> We discussed automating this once before but didn't make a decision:
> http://stdcxx.markmail.org/message/bso6dno3fzm64pfa. I think we ought
> to give some more thought to automating it so I created an enhancement
> request to remind us: http://issues.apache.org/jira/browse/STDCXX-887.

In GNU-style distributions, it's updated in only one place -- in the
configure.in or configure.ac file and propagated from there to other
files.  Still requires a manual edit but at least in only one place
to reduce maintenance.  I don't see how it can be done automatically.

Brad.

Re: svn commit: r649727 - /stdcxx/branches/4.2.x/include/rw/_config.h

Posted by Martin Sebor <se...@roguewave.com>.
vitek@apache.org wrote:
> Author: vitek
> Date: Fri Apr 18 17:10:23 2008
> New Revision: 649727
> 
> URL: http://svn.apache.org/viewvc?rev=649727&view=rev
> Log:
> 2008-04-18  Travis Vitek  <vi...@roguewave.com>
> 
> 	* include/rw/_config.h: Update _RWSTD_VER macro
> 	to correctly reflect the library version.

We discussed automating this once before but didn't make a decision:
http://stdcxx.markmail.org/message/bso6dno3fzm64pfa. I think we ought
to give some more thought to automating it so I created an enhancement
request to remind us: http://issues.apache.org/jira/browse/STDCXX-887.

Martin

> 
> 
> Modified:
>     stdcxx/branches/4.2.x/include/rw/_config.h
> 
> Modified: stdcxx/branches/4.2.x/include/rw/_config.h
> URL: http://svn.apache.org/viewvc/stdcxx/branches/4.2.x/include/rw/_config.h?rev=649727&r1=649726&r2=649727&view=diff
> ==============================================================================
> --- stdcxx/branches/4.2.x/include/rw/_config.h (original)
> +++ stdcxx/branches/4.2.x/include/rw/_config.h Fri Apr 18 17:10:23 2008
> @@ -37,7 +37,7 @@
>  
>  /*** library version numbers and ids **************************************/
>  
> -#define _RWSTD_VER 0x04020001
> +#define _RWSTD_VER 0x04020100
>  //                    | | | |
>  //                   MMmmuupp
>  //                    | | | |
> 
>