[jira] [Comment Edited] (FLINK-15693) Stop receiving incoming RPC messages when RpcEndpoint is closing

["MinWang (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-15693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150261#comment-17150261 ] 

MinWang edited comment on FLINK-15693 at 7/2/20, 1:05 PM:
----------------------------------------------------------

I suppressed the handleRpcInvocation and ran the tests. It’s all passed. It seems no messages out during shutting down. I will keep digging. 


was (Author: anglenet):
I suppressed the handleRpcInvocation and ran the tests. It’s all passed. It seems no messages out. I will keep digging. 

> Stop receiving incoming RPC messages when RpcEndpoint is closing
> ----------------------------------------------------------------
>
>                 Key: FLINK-15693
>                 URL: https://issues.apache.org/jira/browse/FLINK-15693
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / Coordination
>    Affects Versions: 1.9.1, 1.10.0
>            Reporter: Till Rohrmann
>            Priority: Major
>             Fix For: 1.11.0
>
>
> When calling {{RpcEndpoint#closeAsync()}}, the system triggers {{RpcEndpoint#onStop}} and transitions the endpoint into the {{TerminatingState}}. In order to allow asynchronous clean up operations, the main thread executor is not shut down immediately. As a side effect, the {{RpcEndpoint}} still accepts incoming RPC messages from other components. 
> I think it would be cleaner to no longer accept incoming RPC messages once we are in the {{TerminatingState}}. That way we would not worry about the internal state of the {{RpcEndpoint}} when processing RPC messages (similar to [here|https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java#L952]).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)