[GitHub] [skywalking-eyes] zooltd edited a comment on pull request #69: feature: support saving dependencies' licenses

[GitBox <gi...@apache.org>]

zooltd edited a comment on pull request #69:
URL: https://github.com/apache/skywalking-eyes/pull/69#issuecomment-917817905


   This feature attempts to write each pkg's license content to respective files. The license content is resolved by each resolver. However, the resolving behavior of each resolver is inconsistent. To be more specific, in `GoModResolver`, it always record a mod's complete license content, cuz it identifies the mod's license through this content. In `NpmResolver`, it may not record the license content because it identifies a pkg's license through the field in a pkg's `package.json` file in the first priority. In `MavenPomResolver`, it simply records the raw data of the license field in a `pom.xml` file as the license content. So here's the problem, the license content to be written may be an empty string or something irrelevant. Maybe we should standardize each resolver's behavior. If the `LicenseContent` field to be written is empty, then simply write a license template to the file according to the `LicenseSpdxID` field.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org