You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/09 03:30:09 UTC

[GitHub] [arrow-datafusion] dianaclarke commented on a change in pull request #1791: DataFusion + Conbench Integration

dianaclarke commented on a change in pull request #1791:
URL: https://github.com/apache/arrow-datafusion/pull/1791#discussion_r802240777



##########
File path: conbench/.flake8
##########
@@ -0,0 +1,19 @@
+# Licensed to the Apache Software Foundation (ASF) under one

Review comment:
       From a Python perspective, it's probably a mistake to name this directory `conbench`. Thoughts on what you would like `arrow-datafusion/conbench/` to be named?
   
   - `arrow-datafusion/_conbench/`?
   - `arrow-datafusion/conbench-benchmarks/`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org