You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jon Haddad (Jira)" <ji...@apache.org> on 2024/11/15 18:35:00 UTC
[jira] [Comment Edited] (CASSANDRA-20068) Add flag to avoid invalidating key cache on file deletion
[ https://issues.apache.org/jira/browse/CASSANDRA-20068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17898729#comment-17898729 ]
Jon Haddad edited comment on CASSANDRA-20068 at 11/15/24 6:34 PM:
------------------------------------------------------------------
I was doing some perf work this week and noticed this as well. Here's a flame graph showing a significant amount of time spent in key cache invalidation:
!screenshot-1.png!
again with
{noformat}
key_cache_migrate_during_compaction: false{noformat}
!image-2024-11-15-10-33-32-322.png!
was (Author: rustyrazorblade):
I was doing some perf work this week and noticed this as well. Here's a flame graph showing a significant amount of time spent in key cache invalidation:
!screenshot-1.png!
> Add flag to avoid invalidating key cache on file deletion
> ---------------------------------------------------------
>
> Key: CASSANDRA-20068
> URL: https://issues.apache.org/jira/browse/CASSANDRA-20068
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Compaction
> Reporter: Marcus Eriksson
> Assignee: Marcus Eriksson
> Priority: Normal
> Fix For: 5.0.x, 5.1-alpha1
>
> Attachments: image-2024-11-15-10-33-32-322.png, screenshot-1.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> CASSANDRA-17056 changed the way we invalidate key cache when deleting sstables after compaction. It now iterates over all the keys in the keycache and deletes the key if it is for the current sstable.
> It can potentially take several seconds per deleted sstable to do this.
> Patch attached which disables this by default, but can be turned on if anyone relies on this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org