You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "bneradt (via GitHub)" <gi...@apache.org> on 2026/05/20 16:48:55 UTC

[PR] Stabilize parallel AuTest helpers [trafficserver]

bneradt opened a new pull request, #13182:
URL: https://github.com/apache/trafficserver/pull/13182

   Parallel AuTest runs can execute redirect and redirect_actions at the
   same time. Both tests wrote request files into the same generated data
   directory, so one test could overwrite the other's inputs and make
   redirect fail with unrelated redirect_actions requests.
   
   This gives each redirect test its own generated-data directory and
   keeps those directories ignored. This also makes the SIGUSR2 helper
   tolerate processes whose psutil cmdline is unavailable, so process
   scanning does not crash before signaling Traffic Server.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Stabilize parallel AuTest helpers [trafficserver]

Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on code in PR #13182:
URL: https://github.com/apache/trafficserver/pull/13182#discussion_r3276699757


##########
tests/gold_tests/redirect/.gitignore:
##########
@@ -1 +1,3 @@
 generated_test_data/

Review Comment:
   Good point.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Stabilize parallel AuTest helpers [trafficserver]

Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on PR #13182:
URL: https://github.com/apache/trafficserver/pull/13182#issuecomment-4667986324

   Cherry-picked to 10.1.x branch


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Stabilize parallel AuTest helpers [trafficserver]

Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on code in PR #13182:
URL: https://github.com/apache/trafficserver/pull/13182#discussion_r3276319645


##########
tests/gold_tests/logging/ts_process_handler.py:
##########
@@ -36,7 +36,7 @@ def __init__(self, message):
 def get_ts_process_pid(ts_identifier):
     processes = []
     for proc in psutil.process_iter(['cmdline']):
-        commandline = ' '.join(proc.info['cmdline'])
+        commandline = ' '.join(proc.info.get('cmdline') or [])

Review Comment:
   Would a typical Python dev understand at a glance what's going on here? You could use the default value for `get` to make this more conventional for Python.
   
   ```suggestion
   commandline = ' '.join(proc.info.get('cmdline', [])
   ```



##########
tests/gold_tests/redirect/.gitignore:
##########
@@ -1 +1,3 @@
 generated_test_data/

Review Comment:
   Should `generated_test_data` be removed from .gitignore now?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Stabilize parallel AuTest helpers [trafficserver]

Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt merged PR #13182:
URL: https://github.com/apache/trafficserver/pull/13182


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Stabilize parallel AuTest helpers [trafficserver]

Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on PR #13182:
URL: https://github.com/apache/trafficserver/pull/13182#issuecomment-4713983863

   Cherry-picked to 10.2.x


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Stabilize parallel AuTest helpers [trafficserver]

Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on code in PR #13182:
URL: https://github.com/apache/trafficserver/pull/13182#discussion_r3276701087


##########
tests/gold_tests/logging/ts_process_handler.py:
##########
@@ -36,7 +36,7 @@ def __init__(self, message):
 def get_ts_process_pid(ts_identifier):
     processes = []
     for proc in psutil.process_iter(['cmdline']):
-        commandline = ' '.join(proc.info['cmdline'])
+        commandline = ' '.join(proc.info.get('cmdline') or [])

Review Comment:
   Yes, that is better. Thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org