[GitHub] [ozone] hanishakoneru commented on a change in pull request #2491: HDDS-5534. Verify config is updated on all OMs before proceeding with Bootstrap

[GitBox <gi...@apache.org>]

hanishakoneru commented on a change in pull request #2491:
URL: https://github.com/apache/ozone/pull/2491#discussion_r745163855



##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##########
@@ -1453,7 +1559,13 @@ public void updatePeerList(List<String> omNodeIds) {
       // Check if the OM NodeID is already present in the peer list or its
       // the local NodeID.
       if (!peerNodesMap.containsKey(omNodeId) && !isCurrentNode(omNodeId)) {
-        addOMNodeToPeers(omNodeId);
+        try {
+          addOMNodeToPeers(omNodeId);
+        } catch (IOException e) {
+          LOG.error("Fatal Error: Shutting down the system as otherwise it " +

Review comment:
       This function is called from the StateMachine. Any error in SM could be fatal as it diverges the OM states. Let's say  om1 and om2 update their configs about new nodes om4 and om5, but om3 does not as addOMNodeToPeers fails. This will lead to om3 being in a different config without having knowledge about om4 and om5. Now let's say om1 and om2 go down and om4 is the new leader. om3 cannot contact om4 to download a checkpoint if required as it does not know the addresses of om4.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org