[GitHub] [dolphinscheduler] ruanwenjun commented on a change in pull request #5941: [Improvement][Api Module]split alert group list-paging interface

[GitBox <gi...@apache.org>]

ruanwenjun commented on a change in pull request #5941:
URL: https://github.com/apache/dolphinscheduler/pull/5941#discussion_r683056895



##########
File path: dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/AlertGroupMapper.java
##########
@@ -82,4 +83,13 @@
      * @return
      */
     String queryAlertGroupInstanceIdsById(@Param("alertGroupId") int alertGroupId);
+
+    /**
+     * alert group page
+     * @param page page
+     * @param groupName groupName
+     * @return map IPage
+     */
+    IPage<Map<String, Object>> queryAlertGroup(Page<Map<String, Object>> page,

Review comment:
       It might be better to change this method name to `queryAlertGroupName` or add a description on the comments.
   Someone might use this method to get the real `AlertGroup`.
   And if you use map as the result, it's necessary to declare the mapping content.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org