You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/26 04:43:47 UTC
[GitHub] [spark] dilipbiswal commented on a change in pull request #24652:
[SPARK-27782][SQL] Use '#' to mark expression id embedded in the name field
of SubqueryExec operator
dilipbiswal commented on a change in pull request #24652: [SPARK-27782][SQL] Use '#' to mark expression id embedded in the name field of SubqueryExec operator
URL: https://github.com/apache/spark/pull/24652#discussion_r287581643
##########
File path: sql/core/src/test/resources/sql-tests/inputs/subquery/scalar-subquery/scalar-subquery-predicate.sql
##########
@@ -279,3 +279,14 @@ HAVING max(t1b) <= (SELECT max(t2b)
FROM t2
WHERE t2c = t1c
GROUP BY t2c);
+
+-- TC 03.01
+-- explain a simple uncorelated scalar subquery
+SET spark.sql.codegen.wholeStage = true;
Review comment:
@dongjoon-hyun Yes.. this is to bypass the codegenconfigsets combination.. Do you want to mke this test case to a new .sql instead of modifying an existing one ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org