You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gora.apache.org by le...@apache.org on 2013/10/24 20:08:11 UTC
svn commit: r1535466 - in
/gora/branches/GORA_94/gora-core/src/test/java/org/apache/gora/store:
DataStoreTestBase.java DataStoreTestUtil.java
Author: lewismc
Date: Thu Oct 24 18:08:10 2013
New Revision: 1535466
URL: http://svn.apache.org/r1535466
Log:
trivial update to correct compilation of test cases.
Modified:
gora/branches/GORA_94/gora-core/src/test/java/org/apache/gora/store/DataStoreTestBase.java
gora/branches/GORA_94/gora-core/src/test/java/org/apache/gora/store/DataStoreTestUtil.java
Modified: gora/branches/GORA_94/gora-core/src/test/java/org/apache/gora/store/DataStoreTestBase.java
URL: http://svn.apache.org/viewvc/gora/branches/GORA_94/gora-core/src/test/java/org/apache/gora/store/DataStoreTestBase.java?rev=1535466&r1=1535465&r2=1535466&view=diff
==============================================================================
--- gora/branches/GORA_94/gora-core/src/test/java/org/apache/gora/store/DataStoreTestBase.java (original)
+++ gora/branches/GORA_94/gora-core/src/test/java/org/apache/gora/store/DataStoreTestBase.java Thu Oct 24 18:08:10 2013
@@ -19,22 +19,16 @@
package org.apache.gora.store;
import java.io.IOException;
-import java.nio.ByteBuffer;
-
-import org.apache.avro.util.Utf8;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.apache.gora.GoraTestDriver;
import org.apache.gora.examples.generated.Employee;
-import org.apache.gora.examples.generated.Metadata;
import org.apache.gora.examples.generated.WebPage;
import org.junit.After;
import org.junit.AfterClass;
import org.junit.Before;
import org.junit.BeforeClass;
import org.junit.Test;
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNotNull;
/**
* A base class for {@link DataStore} tests. This is just a convenience
Modified: gora/branches/GORA_94/gora-core/src/test/java/org/apache/gora/store/DataStoreTestUtil.java
URL: http://svn.apache.org/viewvc/gora/branches/GORA_94/gora-core/src/test/java/org/apache/gora/store/DataStoreTestUtil.java?rev=1535466&r1=1535465&r2=1535466&view=diff
==============================================================================
--- gora/branches/GORA_94/gora-core/src/test/java/org/apache/gora/store/DataStoreTestUtil.java (original)
+++ gora/branches/GORA_94/gora-core/src/test/java/org/apache/gora/store/DataStoreTestUtil.java Thu Oct 24 18:08:10 2013
@@ -42,7 +42,6 @@ import static org.junit.Assert.assertFal
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.assertNull;
-import org.apache.avro.generic.GenericArray;
import org.apache.avro.util.Utf8;
import org.apache.gora.examples.WebPageDataCreator;
import org.apache.gora.examples.generated.Employee;
@@ -56,7 +55,6 @@ import org.apache.gora.query.Result;
import org.apache.gora.util.AvroUtils;
import org.apache.gora.util.ByteUtils;
import org.apache.gora.util.StringUtils;
-import org.junit.Test;
/**
* Test utilities for DataStores. This utility class provides everything
@@ -248,25 +246,18 @@ public class DataStoreTestUtil {
dataStore.put(ssn, employee);
dataStore.flush();
- // XXX See GORA-216: special case until later reviewed.
- // Like in K-V stores, if retrieved column does not exists ([webpage] case),
- // get() must return 'null'.
- // We prepare an actual weird synthetic test.
-
- // String[] fields = employee.getFields();
- String[] fields = {"name","dateOfBirth","ssn","salary"} ;
-
+ String[] fields = AvroUtils.getPersistentFieldNames(employee);
for(Set<String> subset : StringUtils.powerset(fields)) {
if(subset.isEmpty())
continue;
Employee after = dataStore.get(ssn, subset.toArray(new String[subset.size()]));
Employee expected = new Employee();
for(String field:subset) {
- int index = expected.getFieldIndex(field);
+ int index = expected.getSchema().getField(field).pos();
expected.put(index, employee.get(index));
}
- assertEquals(expected, after);
+ assertEquals(expected, after);
}
}