You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by ji...@apache.org on 2004/08/28 01:49:39 UTC
cvs commit: apache-1.3/src/modules/standard mod_log_forensic.c
jim 2004/08/27 16:49:39
Modified: src CHANGES
src/modules/standard mod_log_forensic.c
Log:
Fix mod_log_forensic bug by applying patch. reported *was* author
of patch, right??
Revision Changes Path
1.1950 +4 -0 apache-1.3/src/CHANGES
Index: CHANGES
===================================================================
RCS file: /home/cvs/apache-1.3/src/CHANGES,v
retrieving revision 1.1949
retrieving revision 1.1950
diff -u -r1.1949 -r1.1950
--- CHANGES 27 Aug 2004 23:44:41 -0000 1.1949
+++ CHANGES 27 Aug 2004 23:49:39 -0000 1.1950
@@ -1,5 +1,9 @@
Changes with Apache 1.3.32
+ *) Fix trivial bug in mod_log_forensic that caused the child
+ to seg fault when certain invalid requests were fired at it with
+ forensic logging is enabled. [Will Slater <Will Slater orbisuk.com>]
+
*) Fix memory leak in the cache handling of mod_rewrite. PR 27862.
[chunyan sheng <shengperson yahoo.com>, Andr� Malo]
1.8 +4 -0 apache-1.3/src/modules/standard/mod_log_forensic.c
Index: mod_log_forensic.c
===================================================================
RCS file: /home/cvs/apache-1.3/src/modules/standard/mod_log_forensic.c,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- mod_log_forensic.c 21 Feb 2004 15:24:36 -0000 1.7
+++ mod_log_forensic.c 27 Aug 2004 23:49:39 -0000 1.8
@@ -233,6 +233,10 @@
return DECLINED;
rcfg = ap_get_module_config(r->request_config, &log_forensic_module);
+
+ if (!rcfg)
+ return DECLINED;
+
s = ap_pstrcat(r->pool, "-", rcfg->id, "\n", NULL);
write(cfg->fd, s, strlen(s));