You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/11/03 02:42:03 UTC
[GitHub] [incubator-kyuubi] hddong opened a new pull request #1325: [KYUUBI#1324] Add resource limit for kyuubi server on kubernetes
hddong opened a new pull request #1325:
URL: https://github.com/apache/incubator-kyuubi/pull/1325
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
Add resource limit config for kyuubi server on kubernetes.
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [X] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #1325: [KYUUBI#1324] Add resource limit for kyuubi server on kubernetes
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #1325:
URL: https://github.com/apache/incubator-kyuubi/pull/1325#discussion_r741611261
##########
File path: docker/helm/templates/kyuubi-deployment.yaml
##########
@@ -46,6 +46,8 @@ spec:
- name: frontend-port
containerPort: {{ .Values.server.bind.port }}
protocol: TCP
+ resources:
+ {{- toYaml .Values.resources | nindent 12 }}
Review comment:
shall we use `indent` rather than `nindent` here ? otherwise we will get a new empty line. I just read some [related docs](https://helm.sh/docs/chart_template_guide/function_list/#nindent).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1325: [KYUUBI#1324] Add resource limit for kyuubi server on kubernetes
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1325:
URL: https://github.com/apache/incubator-kyuubi/pull/1325#issuecomment-958615952
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1325: [KYUUBI#1324] Add resource limit for kyuubi server on kubernetes
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1325:
URL: https://github.com/apache/incubator-kyuubi/pull/1325#discussion_r741585773
##########
File path: docker/helm/values.yaml
##########
@@ -41,4 +41,16 @@ service:
# to change:
# vim kube-apiserver.yaml (usually under path: /etc/kubernetes/manifests/)
# add or change line 'service-node-port-range=1-32767' under kube-apiserver
- port: 30009
\ No newline at end of file
+ port: 30009
+
+resources: {}
+ # Used to specify resource, default unlimited.
+ # If you do want to specify resources:
+ # 1. remove the curly braces after 'resources:'
+ # 2. uncomment the following lines
+ # limits:
+ # cpu: 4
+ # memory: 10Gi
+ # requests:
+ # cpu: 2
+ # memory: 4Gi
Review comment:
nit: add newline eof
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] hddong commented on a change in pull request #1325: [KYUUBI#1324] Add resource limit for kyuubi server on kubernetes
Posted by GitBox <gi...@apache.org>.
hddong commented on a change in pull request #1325:
URL: https://github.com/apache/incubator-kyuubi/pull/1325#discussion_r741592456
##########
File path: docker/helm/values.yaml
##########
@@ -41,4 +41,16 @@ service:
# to change:
# vim kube-apiserver.yaml (usually under path: /etc/kubernetes/manifests/)
# add or change line 'service-node-port-range=1-32767' under kube-apiserver
- port: 30009
\ No newline at end of file
+ port: 30009
+
+resources: {}
+ # Used to specify resource, default unlimited.
+ # If you do want to specify resources:
+ # 1. remove the curly braces after 'resources:'
+ # 2. uncomment the following lines
+ # limits:
+ # cpu: 4
+ # memory: 10Gi
+ # requests:
+ # cpu: 2
+ # memory: 4Gi
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #1325: [KYUUBI#1324] Add resource limit for kyuubi server on kubernetes
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #1325:
URL: https://github.com/apache/incubator-kyuubi/pull/1325#discussion_r741611261
##########
File path: docker/helm/templates/kyuubi-deployment.yaml
##########
@@ -46,6 +46,8 @@ spec:
- name: frontend-port
containerPort: {{ .Values.server.bind.port }}
protocol: TCP
+ resources:
+ {{- toYaml .Values.resources | nindent 12 }}
Review comment:
shall we use `indent` rather than `nindent` here ? otherwise we will get a new empty line. I just read some [related docs](https://helm.sh/docs/chart_template_guide/function_list/#nindent).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1325: [KYUUBI#1324] Add resource limit for kyuubi server on kubernetes
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1325:
URL: https://github.com/apache/incubator-kyuubi/pull/1325#issuecomment-958615952
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1325](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (51f5fbe) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/c78fe427edf3ea2e4d94e9cc1801058818438db3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c78fe42) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1325 +/- ##
============================================
+ Coverage 78.51% 78.52% +0.01%
Complexity 110 110
============================================
Files 178 178
Lines 7241 7245 +4
Branches 887 887
============================================
+ Hits 5685 5689 +4
Misses 1071 1071
Partials 485 485
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25JbXBsLnNjYWxh) | `89.58% <0.00%> (-0.22%)` | :arrow_down: |
| [...in/scala/org/apache/kyuubi/sql/KyuubiSQLConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlTUUxDb25mLnNjYWxh) | `100.00% <0.00%> (ø)` | |
| [...he/kyuubi/sql/zorder/ZorderSqlAstBuilderBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyU3FsQXN0QnVpbGRlckJhc2Uuc2NhbGE=) | `28.64% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c78fe42...51f5fbe](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you closed pull request #1325: [KYUUBI#1324] Add resource limit for kyuubi server on kubernetes
Posted by GitBox <gi...@apache.org>.
ulysses-you closed pull request #1325:
URL: https://github.com/apache/incubator-kyuubi/pull/1325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1325: [KYUUBI#1324] Add resource limit for kyuubi server on kubernetes
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1325:
URL: https://github.com/apache/incubator-kyuubi/pull/1325#issuecomment-958615952
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1325](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (51f5fbe) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/c78fe427edf3ea2e4d94e9cc1801058818438db3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c78fe42) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1325 +/- ##
============================================
+ Coverage 78.51% 78.52% +0.01%
Complexity 110 110
============================================
Files 178 178
Lines 7241 7245 +4
Branches 887 887
============================================
+ Hits 5685 5689 +4
Misses 1071 1071
Partials 485 485
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25JbXBsLnNjYWxh) | `89.58% <0.00%> (-0.22%)` | :arrow_down: |
| [...in/scala/org/apache/kyuubi/sql/KyuubiSQLConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlTUUxDb25mLnNjYWxh) | `100.00% <0.00%> (ø)` | |
| [...he/kyuubi/sql/zorder/ZorderSqlAstBuilderBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyU3FsQXN0QnVpbGRlckJhc2Uuc2NhbGE=) | `28.64% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c78fe42...51f5fbe](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1325: [KYUUBI#1324] Add resource limit for kyuubi server on kubernetes
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1325:
URL: https://github.com/apache/incubator-kyuubi/pull/1325#issuecomment-958615952
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1325](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (51f5fbe) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/c78fe427edf3ea2e4d94e9cc1801058818438db3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c78fe42) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 51f5fbe differs from pull request most recent head 8ec3d98. Consider uploading reports for the commit 8ec3d98 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1325 +/- ##
============================================
+ Coverage 78.51% 78.52% +0.01%
Complexity 110 110
============================================
Files 178 178
Lines 7241 7245 +4
Branches 887 887
============================================
+ Hits 5685 5689 +4
Misses 1071 1071
Partials 485 485
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25JbXBsLnNjYWxh) | `89.58% <0.00%> (-0.22%)` | :arrow_down: |
| [...in/scala/org/apache/kyuubi/sql/KyuubiSQLConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlTUUxDb25mLnNjYWxh) | `100.00% <0.00%> (ø)` | |
| [...he/kyuubi/sql/zorder/ZorderSqlAstBuilderBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyU3FsQXN0QnVpbGRlckJhc2Uuc2NhbGE=) | `28.64% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c78fe42...8ec3d98](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #1325: [KYUUBI#1324] Add resource limit for kyuubi server on kubernetes
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #1325:
URL: https://github.com/apache/incubator-kyuubi/pull/1325#issuecomment-958694759
thanks, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1325: [KYUUBI#1324] Add resource limit for kyuubi server on kubernetes
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1325:
URL: https://github.com/apache/incubator-kyuubi/pull/1325#issuecomment-958615952
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1325: [KYUUBI#1324] Add resource limit for kyuubi server on kubernetes
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1325:
URL: https://github.com/apache/incubator-kyuubi/pull/1325#discussion_r741585773
##########
File path: docker/helm/values.yaml
##########
@@ -41,4 +41,16 @@ service:
# to change:
# vim kube-apiserver.yaml (usually under path: /etc/kubernetes/manifests/)
# add or change line 'service-node-port-range=1-32767' under kube-apiserver
- port: 30009
\ No newline at end of file
+ port: 30009
+
+resources: {}
+ # Used to specify resource, default unlimited.
+ # If you do want to specify resources:
+ # 1. remove the curly braces after 'resources:'
+ # 2. uncomment the following lines
+ # limits:
+ # cpu: 4
+ # memory: 10Gi
+ # requests:
+ # cpu: 2
+ # memory: 4Gi
Review comment:
nit: add newline at eof
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1325: [KYUUBI#1324] Add resource limit for kyuubi server on kubernetes
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1325:
URL: https://github.com/apache/incubator-kyuubi/pull/1325#discussion_r741585773
##########
File path: docker/helm/values.yaml
##########
@@ -41,4 +41,16 @@ service:
# to change:
# vim kube-apiserver.yaml (usually under path: /etc/kubernetes/manifests/)
# add or change line 'service-node-port-range=1-32767' under kube-apiserver
- port: 30009
\ No newline at end of file
+ port: 30009
+
+resources: {}
+ # Used to specify resource, default unlimited.
+ # If you do want to specify resources:
+ # 1. remove the curly braces after 'resources:'
+ # 2. uncomment the following lines
+ # limits:
+ # cpu: 4
+ # memory: 10Gi
+ # requests:
+ # cpu: 2
+ # memory: 4Gi
Review comment:
nit: add newline eof
##########
File path: docker/helm/values.yaml
##########
@@ -41,4 +41,16 @@ service:
# to change:
# vim kube-apiserver.yaml (usually under path: /etc/kubernetes/manifests/)
# add or change line 'service-node-port-range=1-32767' under kube-apiserver
- port: 30009
\ No newline at end of file
+ port: 30009
+
+resources: {}
+ # Used to specify resource, default unlimited.
+ # If you do want to specify resources:
+ # 1. remove the curly braces after 'resources:'
+ # 2. uncomment the following lines
+ # limits:
+ # cpu: 4
+ # memory: 10Gi
+ # requests:
+ # cpu: 2
+ # memory: 4Gi
Review comment:
nit: add newline at eof
##########
File path: docker/helm/values.yaml
##########
@@ -41,4 +41,16 @@ service:
# to change:
# vim kube-apiserver.yaml (usually under path: /etc/kubernetes/manifests/)
# add or change line 'service-node-port-range=1-32767' under kube-apiserver
- port: 30009
\ No newline at end of file
+ port: 30009
+
+resources: {}
+ # Used to specify resource, default unlimited.
+ # If you do want to specify resources:
+ # 1. remove the curly braces after 'resources:'
+ # 2. uncomment the following lines
+ # limits:
+ # cpu: 4
+ # memory: 10Gi
+ # requests:
+ # cpu: 2
+ # memory: 4Gi
Review comment:
nit: add newline eof
##########
File path: docker/helm/values.yaml
##########
@@ -41,4 +41,16 @@ service:
# to change:
# vim kube-apiserver.yaml (usually under path: /etc/kubernetes/manifests/)
# add or change line 'service-node-port-range=1-32767' under kube-apiserver
- port: 30009
\ No newline at end of file
+ port: 30009
+
+resources: {}
+ # Used to specify resource, default unlimited.
+ # If you do want to specify resources:
+ # 1. remove the curly braces after 'resources:'
+ # 2. uncomment the following lines
+ # limits:
+ # cpu: 4
+ # memory: 10Gi
+ # requests:
+ # cpu: 2
+ # memory: 4Gi
Review comment:
nit: add newline at eof
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #1325: [KYUUBI#1324] Add resource limit for kyuubi server on kubernetes
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #1325:
URL: https://github.com/apache/incubator-kyuubi/pull/1325#issuecomment-958694759
thanks, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1325: [KYUUBI#1324] Add resource limit for kyuubi server on kubernetes
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1325:
URL: https://github.com/apache/incubator-kyuubi/pull/1325#issuecomment-958615952
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1325](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (51f5fbe) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/c78fe427edf3ea2e4d94e9cc1801058818438db3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c78fe42) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1325 +/- ##
============================================
+ Coverage 78.51% 78.52% +0.01%
Complexity 110 110
============================================
Files 178 178
Lines 7241 7245 +4
Branches 887 887
============================================
+ Hits 5685 5689 +4
Misses 1071 1071
Partials 485 485
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25JbXBsLnNjYWxh) | `89.58% <0.00%> (-0.22%)` | :arrow_down: |
| [...in/scala/org/apache/kyuubi/sql/KyuubiSQLConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlTUUxDb25mLnNjYWxh) | `100.00% <0.00%> (ø)` | |
| [...he/kyuubi/sql/zorder/ZorderSqlAstBuilderBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyU3FsQXN0QnVpbGRlckJhc2Uuc2NhbGE=) | `28.64% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c78fe42...51f5fbe](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1325: [KYUUBI#1324] Add resource limit for kyuubi server on kubernetes
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1325:
URL: https://github.com/apache/incubator-kyuubi/pull/1325#issuecomment-958615952
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1325](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (51f5fbe) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/c78fe427edf3ea2e4d94e9cc1801058818438db3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c78fe42) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1325 +/- ##
============================================
+ Coverage 78.51% 78.52% +0.01%
Complexity 110 110
============================================
Files 178 178
Lines 7241 7245 +4
Branches 887 887
============================================
+ Hits 5685 5689 +4
Misses 1071 1071
Partials 485 485
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25JbXBsLnNjYWxh) | `89.58% <0.00%> (-0.22%)` | :arrow_down: |
| [...in/scala/org/apache/kyuubi/sql/KyuubiSQLConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlTUUxDb25mLnNjYWxh) | `100.00% <0.00%> (ø)` | |
| [...he/kyuubi/sql/zorder/ZorderSqlAstBuilderBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyU3FsQXN0QnVpbGRlckJhc2Uuc2NhbGE=) | `28.64% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c78fe42...51f5fbe](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] hddong commented on a change in pull request #1325: [KYUUBI#1324] Add resource limit for kyuubi server on kubernetes
Posted by GitBox <gi...@apache.org>.
hddong commented on a change in pull request #1325:
URL: https://github.com/apache/incubator-kyuubi/pull/1325#discussion_r741592456
##########
File path: docker/helm/values.yaml
##########
@@ -41,4 +41,16 @@ service:
# to change:
# vim kube-apiserver.yaml (usually under path: /etc/kubernetes/manifests/)
# add or change line 'service-node-port-range=1-32767' under kube-apiserver
- port: 30009
\ No newline at end of file
+ port: 30009
+
+resources: {}
+ # Used to specify resource, default unlimited.
+ # If you do want to specify resources:
+ # 1. remove the curly braces after 'resources:'
+ # 2. uncomment the following lines
+ # limits:
+ # cpu: 4
+ # memory: 10Gi
+ # requests:
+ # cpu: 2
+ # memory: 4Gi
Review comment:
Done
##########
File path: docker/helm/templates/kyuubi-deployment.yaml
##########
@@ -46,6 +46,8 @@ spec:
- name: frontend-port
containerPort: {{ .Values.server.bind.port }}
protocol: TCP
+ resources:
+ {{- toYaml .Values.resources | nindent 12 }}
Review comment:
> shall we use `indent` rather than `nindent` here ? otherwise we will get a new empty line. I just read some [related docs](https://helm.sh/docs/chart_template_guide/function_list/#nindent).
It seems that it must be `nindent` here, if use `indent`, we will get error ` mapping values are not allowed in this context`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] hddong commented on a change in pull request #1325: [KYUUBI#1324] Add resource limit for kyuubi server on kubernetes
Posted by GitBox <gi...@apache.org>.
hddong commented on a change in pull request #1325:
URL: https://github.com/apache/incubator-kyuubi/pull/1325#discussion_r741652569
##########
File path: docker/helm/templates/kyuubi-deployment.yaml
##########
@@ -46,6 +46,8 @@ spec:
- name: frontend-port
containerPort: {{ .Values.server.bind.port }}
protocol: TCP
+ resources:
+ {{- toYaml .Values.resources | nindent 12 }}
Review comment:
> shall we use `indent` rather than `nindent` here ? otherwise we will get a new empty line. I just read some [related docs](https://helm.sh/docs/chart_template_guide/function_list/#nindent).
It seems that it must be `nindent` here, if use `indent`, we will get error ` mapping values are not allowed in this context`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #1325: [KYUUBI#1324] Add resource limit for kyuubi server on kubernetes
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #1325:
URL: https://github.com/apache/incubator-kyuubi/pull/1325#discussion_r741611261
##########
File path: docker/helm/templates/kyuubi-deployment.yaml
##########
@@ -46,6 +46,8 @@ spec:
- name: frontend-port
containerPort: {{ .Values.server.bind.port }}
protocol: TCP
+ resources:
+ {{- toYaml .Values.resources | nindent 12 }}
Review comment:
shall we use `indent` rather than `nindent` here ? otherwise we will get a new empty line. I just read some [related docs](https://helm.sh/docs/chart_template_guide/function_list/#nindent).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you closed pull request #1325: [KYUUBI#1324] Add resource limit for kyuubi server on kubernetes
Posted by GitBox <gi...@apache.org>.
ulysses-you closed pull request #1325:
URL: https://github.com/apache/incubator-kyuubi/pull/1325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1325: [KYUUBI#1324] Add resource limit for kyuubi server on kubernetes
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1325:
URL: https://github.com/apache/incubator-kyuubi/pull/1325#issuecomment-958615952
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you closed pull request #1325: [KYUUBI#1324] Add resource limit for kyuubi server on kubernetes
Posted by GitBox <gi...@apache.org>.
ulysses-you closed pull request #1325:
URL: https://github.com/apache/incubator-kyuubi/pull/1325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #1325: [KYUUBI#1324] Add resource limit for kyuubi server on kubernetes
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #1325:
URL: https://github.com/apache/incubator-kyuubi/pull/1325#discussion_r741611261
##########
File path: docker/helm/templates/kyuubi-deployment.yaml
##########
@@ -46,6 +46,8 @@ spec:
- name: frontend-port
containerPort: {{ .Values.server.bind.port }}
protocol: TCP
+ resources:
+ {{- toYaml .Values.resources | nindent 12 }}
Review comment:
shall we use `indent` rather than `nindent` here ? otherwise we will get a new empty line. I just read some [related docs](https://helm.sh/docs/chart_template_guide/function_list/#nindent).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1325: [KYUUBI#1324] Add resource limit for kyuubi server on kubernetes
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1325:
URL: https://github.com/apache/incubator-kyuubi/pull/1325#discussion_r741585773
##########
File path: docker/helm/values.yaml
##########
@@ -41,4 +41,16 @@ service:
# to change:
# vim kube-apiserver.yaml (usually under path: /etc/kubernetes/manifests/)
# add or change line 'service-node-port-range=1-32767' under kube-apiserver
- port: 30009
\ No newline at end of file
+ port: 30009
+
+resources: {}
+ # Used to specify resource, default unlimited.
+ # If you do want to specify resources:
+ # 1. remove the curly braces after 'resources:'
+ # 2. uncomment the following lines
+ # limits:
+ # cpu: 4
+ # memory: 10Gi
+ # requests:
+ # cpu: 2
+ # memory: 4Gi
Review comment:
nit: add newline eof
##########
File path: docker/helm/values.yaml
##########
@@ -41,4 +41,16 @@ service:
# to change:
# vim kube-apiserver.yaml (usually under path: /etc/kubernetes/manifests/)
# add or change line 'service-node-port-range=1-32767' under kube-apiserver
- port: 30009
\ No newline at end of file
+ port: 30009
+
+resources: {}
+ # Used to specify resource, default unlimited.
+ # If you do want to specify resources:
+ # 1. remove the curly braces after 'resources:'
+ # 2. uncomment the following lines
+ # limits:
+ # cpu: 4
+ # memory: 10Gi
+ # requests:
+ # cpu: 2
+ # memory: 4Gi
Review comment:
nit: add newline at eof
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #1325: [KYUUBI#1324] Add resource limit for kyuubi server on kubernetes
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #1325:
URL: https://github.com/apache/incubator-kyuubi/pull/1325#issuecomment-958694759
thanks, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] hddong commented on a change in pull request #1325: [KYUUBI#1324] Add resource limit for kyuubi server on kubernetes
Posted by GitBox <gi...@apache.org>.
hddong commented on a change in pull request #1325:
URL: https://github.com/apache/incubator-kyuubi/pull/1325#discussion_r741592456
##########
File path: docker/helm/values.yaml
##########
@@ -41,4 +41,16 @@ service:
# to change:
# vim kube-apiserver.yaml (usually under path: /etc/kubernetes/manifests/)
# add or change line 'service-node-port-range=1-32767' under kube-apiserver
- port: 30009
\ No newline at end of file
+ port: 30009
+
+resources: {}
+ # Used to specify resource, default unlimited.
+ # If you do want to specify resources:
+ # 1. remove the curly braces after 'resources:'
+ # 2. uncomment the following lines
+ # limits:
+ # cpu: 4
+ # memory: 10Gi
+ # requests:
+ # cpu: 2
+ # memory: 4Gi
Review comment:
Done
##########
File path: docker/helm/templates/kyuubi-deployment.yaml
##########
@@ -46,6 +46,8 @@ spec:
- name: frontend-port
containerPort: {{ .Values.server.bind.port }}
protocol: TCP
+ resources:
+ {{- toYaml .Values.resources | nindent 12 }}
Review comment:
> shall we use `indent` rather than `nindent` here ? otherwise we will get a new empty line. I just read some [related docs](https://helm.sh/docs/chart_template_guide/function_list/#nindent).
It seems that it must be `nindent` here, if use `indent`, we will get error ` mapping values are not allowed in this context`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] hddong commented on a change in pull request #1325: [KYUUBI#1324] Add resource limit for kyuubi server on kubernetes
Posted by GitBox <gi...@apache.org>.
hddong commented on a change in pull request #1325:
URL: https://github.com/apache/incubator-kyuubi/pull/1325#discussion_r741592456
##########
File path: docker/helm/values.yaml
##########
@@ -41,4 +41,16 @@ service:
# to change:
# vim kube-apiserver.yaml (usually under path: /etc/kubernetes/manifests/)
# add or change line 'service-node-port-range=1-32767' under kube-apiserver
- port: 30009
\ No newline at end of file
+ port: 30009
+
+resources: {}
+ # Used to specify resource, default unlimited.
+ # If you do want to specify resources:
+ # 1. remove the curly braces after 'resources:'
+ # 2. uncomment the following lines
+ # limits:
+ # cpu: 4
+ # memory: 10Gi
+ # requests:
+ # cpu: 2
+ # memory: 4Gi
Review comment:
Done
##########
File path: docker/helm/templates/kyuubi-deployment.yaml
##########
@@ -46,6 +46,8 @@ spec:
- name: frontend-port
containerPort: {{ .Values.server.bind.port }}
protocol: TCP
+ resources:
+ {{- toYaml .Values.resources | nindent 12 }}
Review comment:
> shall we use `indent` rather than `nindent` here ? otherwise we will get a new empty line. I just read some [related docs](https://helm.sh/docs/chart_template_guide/function_list/#nindent).
It seems that it must be `nindent` here, if use `indent`, we will get error ` mapping values are not allowed in this context`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1325: [KYUUBI#1324] Add resource limit for kyuubi server on kubernetes
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1325:
URL: https://github.com/apache/incubator-kyuubi/pull/1325#issuecomment-958615952
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1325](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8ec3d98) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/c78fe427edf3ea2e4d94e9cc1801058818438db3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c78fe42) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1325 +/- ##
============================================
+ Coverage 78.51% 78.52% +0.01%
Complexity 110 110
============================================
Files 178 178
Lines 7241 7245 +4
Branches 887 887
============================================
+ Hits 5685 5689 +4
Misses 1071 1071
Partials 485 485
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25JbXBsLnNjYWxh) | `89.58% <0.00%> (-0.22%)` | :arrow_down: |
| [...in/scala/org/apache/kyuubi/sql/KyuubiSQLConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlTUUxDb25mLnNjYWxh) | `100.00% <0.00%> (ø)` | |
| [...he/kyuubi/sql/zorder/ZorderSqlAstBuilderBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyU3FsQXN0QnVpbGRlckJhc2Uuc2NhbGE=) | `28.64% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c78fe42...8ec3d98](https://codecov.io/gh/apache/incubator-kyuubi/pull/1325?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org