[GitHub] spark pull request #16646: [SPARK-19291][SPARKR][ML] spark.gaussianMixture s...

[jkbradley <gi...@git.apache.org>]

Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16646#discussion_r99253729
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/r/GaussianMixtureWrapper.scala ---
    @@ -124,7 +129,8 @@ private[r] object GaussianMixtureWrapper extends MLReadable[GaussianMixtureWrapp
           val rMetadataStr = sc.textFile(rMetadataPath, 1).first()
           val rMetadata = parse(rMetadataStr)
           val dim = (rMetadata \ "dim").extract[Int]
    -      new GaussianMixtureWrapper(pipeline, dim, isLoaded = true)
    +      val logLikelihood = (rMetadata \ "logLikelihood").extract[Double]
    +      new GaussianMixtureWrapper(pipeline, dim, logLikelihood, isLoaded = true)
    --- End diff --
    
    Breaking it is OK with me.  Thanks for adding it to the "changes of behavior" JIRA for tracking!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org