You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kylin.apache.org by "Shaofeng SHI (JIRA)" <ji...@apache.org> on 2017/07/19 03:10:00 UTC

[jira] [Commented] (KYLIN-2745) Remove eclipse .settings directory from each module

    [ https://issues.apache.org/jira/browse/KYLIN-2745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092506#comment-16092506 ] 

Shaofeng SHI commented on KYLIN-2745:
-------------------------------------

Thanks Nirav; The patch looks good to me (I'm using IntelliJ). [~liyang.gmt8@gmail.com] Yang, I know you're using Eclipse, are you okay with this?

> Remove eclipse .settings directory from each module
> ---------------------------------------------------
>
>                 Key: KYLIN-2745
>                 URL: https://issues.apache.org/jira/browse/KYLIN-2745
>             Project: Kylin
>          Issue Type: Task
>    Affects Versions: Future, v2.0.0
>            Reporter: nirav patel
>            Assignee: nirav patel
>             Fix For: Future
>
>         Attachments: KYLIN-2745.patch
>
>
> I think this directory should not be part of git repo at all. It should be listed in .gitignore file. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)