You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beam.apache.org by Keunhyun Oh <oc...@gmail.com> on 2020/01/13 06:06:06 UTC
Ask about beam pull requests
I want to make pull request about BEAM-9094 (
https://issues.apache.org/jira/browse/BEAM-9094)
My tree is https://github.com/ocworld/beam/tree/BEAM-9094-add-aws-s3-options
When trying to create a pull request issue, It is needed for me to assign
reviewers.
Who can review my request?
Re: Ask about beam pull requests
Posted by Pablo Estrada <pa...@google.com>.
... what that means is that you can tag me on github, and I'll take a look,
yes : ) I'm 'pabloem'.
On Mon, Jan 13, 2020 at 9:59 AM Pablo Estrada <pa...@google.com> wrote:
> I reviewed the first PR, so I'm happy to review others.
>
> On Mon, Jan 13, 2020 at 9:42 AM Robert Bradshaw <ro...@google.com>
> wrote:
>
>> One thing you could do is ask for a history [1] of the file and see if
>> there are any possible candidates (e.g. apache beam comitters [2]).
>>
>> [1]
>> https://github.com/ocworld/beam/blame/259f6174ce52e6317a5b4fe7ed3a126153aaaad3/sdks/python/apache_beam/io/aws/clients/s3/boto3_client.py
>> [2] https://projects.apache.org/committee.html?beam
>>
>> If nothing obvious comes up, feel free to create the pull requests and
>> ask on this list if anyone would be able to review (giving some
>> context, e.g. adding some options to the S3 filesystem in Python).
>>
>> On Mon, Jan 13, 2020 at 9:31 AM Keunhyun Oh <oc...@gmail.com> wrote:
>> >
>> > I want to make pull request about BEAM-9094 (
>> https://issues.apache.org/jira/browse/BEAM-9094)
>> >
>> > My tree is
>> https://github.com/ocworld/beam/tree/BEAM-9094-add-aws-s3-options
>> >
>> > When trying to create a pull request issue, It is needed for me to
>> assign reviewers.
>> >
>> > Who can review my request?
>> >
>>
>
Re: Ask about beam pull requests
Posted by Pablo Estrada <pa...@google.com>.
I reviewed the first PR, so I'm happy to review others.
On Mon, Jan 13, 2020 at 9:42 AM Robert Bradshaw <ro...@google.com> wrote:
> One thing you could do is ask for a history [1] of the file and see if
> there are any possible candidates (e.g. apache beam comitters [2]).
>
> [1]
> https://github.com/ocworld/beam/blame/259f6174ce52e6317a5b4fe7ed3a126153aaaad3/sdks/python/apache_beam/io/aws/clients/s3/boto3_client.py
> [2] https://projects.apache.org/committee.html?beam
>
> If nothing obvious comes up, feel free to create the pull requests and
> ask on this list if anyone would be able to review (giving some
> context, e.g. adding some options to the S3 filesystem in Python).
>
> On Mon, Jan 13, 2020 at 9:31 AM Keunhyun Oh <oc...@gmail.com> wrote:
> >
> > I want to make pull request about BEAM-9094 (
> https://issues.apache.org/jira/browse/BEAM-9094)
> >
> > My tree is
> https://github.com/ocworld/beam/tree/BEAM-9094-add-aws-s3-options
> >
> > When trying to create a pull request issue, It is needed for me to
> assign reviewers.
> >
> > Who can review my request?
> >
>
Re: Ask about beam pull requests
Posted by Robert Bradshaw <ro...@google.com>.
One thing you could do is ask for a history [1] of the file and see if
there are any possible candidates (e.g. apache beam comitters [2]).
[1] https://github.com/ocworld/beam/blame/259f6174ce52e6317a5b4fe7ed3a126153aaaad3/sdks/python/apache_beam/io/aws/clients/s3/boto3_client.py
[2] https://projects.apache.org/committee.html?beam
If nothing obvious comes up, feel free to create the pull requests and
ask on this list if anyone would be able to review (giving some
context, e.g. adding some options to the S3 filesystem in Python).
On Mon, Jan 13, 2020 at 9:31 AM Keunhyun Oh <oc...@gmail.com> wrote:
>
> I want to make pull request about BEAM-9094 (https://issues.apache.org/jira/browse/BEAM-9094)
>
> My tree is https://github.com/ocworld/beam/tree/BEAM-9094-add-aws-s3-options
>
> When trying to create a pull request issue, It is needed for me to assign reviewers.
>
> Who can review my request?
>