You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Budnik <ab...@mesosphere.com> on 2017/07/04 14:00:39 UTC
Review Request 60636: Added method that returns allocated resources
for framework.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60636/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and haosdent huang.
Bugs: MESOS-6441
https://issues.apache.org/jira/browse/MESOS-6441
Repository: mesos
Description
-------
Added method that returns allocated resources for framework.
Diffs (updated)
-----
src/slave/slave.hpp 5ede32d00c5dbf18dc0639ec7af5d2a86f86f619
src/slave/slave.cpp 0e24b8cb8d1020af515e3d1862e121e1daf82ce9
Diff: https://reviews.apache.org/r/60636/diff/1/
Testing
-------
make check
Thanks,
Andrei Budnik
Re: Review Request 60636: Added method returning allocated resources
for framework.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60636/#review180595
-----------------------------------------------------------
Fix it, then Ship it!
Looks good, thanks Andrei!
What I'll do is commit this now and use the existing `executor->resources` with a TODO to fix it, and you can update this code in https://reviews.apache.org/r/60867/ to instead call `executor->allocatedResources()` when you remove `Executor::resources`.
src/slave/slave.cpp
Line 1 (original)
<https://reviews.apache.org/r/60636/#comment255797>
Whoops? If you want to remove this can you submit a different patch? We strive to have patches that don't contain a mix of unrelated changes.
src/slave/slave.cpp
Lines 7493-7494 (patched)
<https://reviews.apache.org/r/60636/#comment255798>
s/ &/& /
src/slave/slave.cpp
Lines 7499 (patched)
<https://reviews.apache.org/r/60636/#comment255799>
newline here
- Benjamin Mahler
On July 4, 2017, 2 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60636/
> -----------------------------------------------------------
>
> (Updated July 4, 2017, 2 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and haosdent huang.
>
>
> Bugs: MESOS-6441
> https://issues.apache.org/jira/browse/MESOS-6441
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added method returning allocated resources for framework.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 5ede32d00c5dbf18dc0639ec7af5d2a86f86f619
> src/slave/slave.cpp 64d24113a1c29a6a9b8401151e6a9fd92511ae40
>
>
> Diff: https://reviews.apache.org/r/60636/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Andrei Budnik
>
>