You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by twilmes <gi...@git.apache.org> on 2016/11/20 21:34:04 UTC

[GitHub] tinkerpop pull request #504: TINKERPOP-1548: Traversals can complete before ...

GitHub user twilmes opened a pull request:

    https://github.com/apache/tinkerpop/pull/504

    TINKERPOP-1548: Traversals can complete before interrupted in TraversalInterruptionComputerTest

    I added a short sleep to prevent traversal from finishing before it can be interrupted during `TraversalInterruptionComputerTest`.
    
    This is a small update but I want to make sure this doesn't cause any build issues for folks.  I was getting this failure before the fix regularly.  After this fix, I've had 10 good runs without issue also `docker/build.sh -t -i -n` succeeded.
    
    VOTE: +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1548

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/504.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #504
    
----
commit 1d9725418fa53e0c0baa5c9982a9aaa1dd31e0d7
Author: Ted Wilmes <tw...@gmail.com>
Date:   2016-11-20T14:02:47Z

    Added a short sleep to prevent traversal from finishing before it can be interrupted.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop pull request #504: TINKERPOP-1548: Traversals can complete before ...

Posted by robertdale <gi...@git.apache.org>.
Github user robertdale commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/504#discussion_r88893084
  
    --- Diff: gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/TraversalInterruptionComputerTest.java ---
    @@ -86,7 +97,7 @@ public void shouldRespectThreadInterruptionInVertexStep() throws Exception {
     
             // total time for test should not exceed 5 seconds - this prevents the test from just hanging and allows
             // it to finish with failure
    -        assertThat(startedIterating.await(5000, TimeUnit.MILLISECONDS), CoreMatchers.is(true));
    +        assertThat(startedIterating.await(1000, TimeUnit.MILLISECONDS), CoreMatchers.is(true));
    --- End diff --
    
    Why not just leave this as 5s?  Seems to work against the fix.  What is the actual timeout time value? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop pull request #504: TINKERPOP-1548: Traversals can complete before ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/tinkerpop/pull/504


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop pull request #504: TINKERPOP-1548: Traversals can complete before ...

Posted by twilmes <gi...@git.apache.org>.
Github user twilmes commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/504#discussion_r88901766
  
    --- Diff: gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/TraversalInterruptionComputerTest.java ---
    @@ -86,7 +97,7 @@ public void shouldRespectThreadInterruptionInVertexStep() throws Exception {
     
             // total time for test should not exceed 5 seconds - this prevents the test from just hanging and allows
             // it to finish with failure
    -        assertThat(startedIterating.await(5000, TimeUnit.MILLISECONDS), CoreMatchers.is(true));
    +        assertThat(startedIterating.await(1000, TimeUnit.MILLISECONDS), CoreMatchers.is(true));
    --- End diff --
    
    When I determined the timing issue was related to the traversal finishing first as opposed to it not having enough time to start I figured I could experiment with lowering this but it was admittedly a shot in the dark at what the "right" number is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #504: TINKERPOP-1548: Traversals can complete before interru...

Posted by robertdale <gi...@git.apache.org>.
Github user robertdale commented on the issue:

    https://github.com/apache/tinkerpop/pull/504
  
    I've seen this on master.
    
    VOTE: +1



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #504: TINKERPOP-1548: Traversals can complete before interru...

Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/504
  
    I did several local and docker builds and it works - of course, it never really failed on my system. Travis is happy too where we sometimes saw failure on this so given that:
    
    VOTE +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---