[GitHub] [incubator-apisix] spacewander commented on a change in pull request #822: change: don't strip square brackets from the IPv6

[GitBox <gi...@apache.org>]

spacewander commented on a change in pull request #822: change: don't strip square brackets from the IPv6
URL: https://github.com/apache/incubator-apisix/pull/822#discussion_r344531822
 
 

 ##########
 File path: rockspec/apisix-master-0.rockspec
 ##########
 @@ -48,6 +48,7 @@ dependencies = {
     "lua-tinyyaml = 0.1",
     "iresty-nginx-lua-prometheus = 0.20190917",
     "jsonschema = 0.4",
+    "lua-resty-ipmatcher = 0.3",
 
 Review comment:
   @membphis 
   I think it would be better to list lua-resty-ipmatcher as a dependency here since APISIX depends on it directly. If one day we remove lua-resty-radixtree, lua-resty-ipmatcher should not be removed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services