[GitHub] [spark] Yikun removed a comment on pull request #35640: [SPARK-38187][K8S] Support resource reservation with volcano implementations

[GitBox <gi...@apache.org>]

Yikun removed a comment on pull request #35640:
URL: https://github.com/apache/spark/pull/35640#issuecomment-1061266014


   @dongjoon-hyun I'm not sure there were some misunderstanding, something below might help you understand.
   
   We configure pod one by one but we only return the PreAdditionalK8SResource once. So there are only one podgroup is created for one job in current implementation.（the pre kubernetes only calls in driver side).
   
   > It seems that you decided not to use volcano API for some reasons
   
   No more hidden reason, just make sure it can be more generic, then it can be created by [prekubernetes create]( https://github.com/apache/spark/blob/master/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala#L140-L140). So we only use volcano model in here. 
   
   > Can we use new DefaultVolcanoClient().podGroups().load()?
   
   if you meaned use this to build volcano-model, client side yaml load could be a alternative way to complete this, but I think we still need to left placeholder in yaml? and do format in feature step? This perhaps not flexiable, and a little bit hard to maintain.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org