[GitHub] jvrao commented on a change in pull request #1091: BOOKKEEPER-1063:Write keeps refCnt longer

[GitBox <gi...@apache.org>]

jvrao commented on a change in pull request #1091: BOOKKEEPER-1063:Write keeps refCnt longer
URL: https://github.com/apache/bookkeeper/pull/1091#discussion_r165187086
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingAddOp.java
 ##########
 @@ -232,6 +231,7 @@ public void safeRun() {
                 sendWriteRequest(writeSet.get(i));
             }
         } finally {
+            hasRun = true;
 
 Review comment:
   I thought it is good to set it after it actually finished running. Do you see any issues with it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services