[GitHub] john-bodley commented on a change in pull request #5500: [security] allow security manager provide error message

[GitBox <gi...@apache.org>]

john-bodley commented on a change in pull request #5500: [security] allow security manager provide error message
URL: https://github.com/apache/incubator-superset/pull/5500#discussion_r205891899
 
 

 ##########
 File path: superset/views/core.py
 ##########
 @@ -1260,9 +1255,11 @@ def explore(self, datasource_type=None, datasource_id=None):
             flash(DATASOURCE_MISSING_ERR, 'danger')
             return redirect(error_redirect)
 
-        if not security_manager.datasource_access(datasource):
+        if config.get('ENABLE_ACCESS_REQUEST') and (
 
 Review comment:
   Why was this check added?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org