[GitHub] [fineract] DylanRobson opened a new pull request #622: Fineract-722

[GitBox <gi...@apache.org>]

DylanRobson opened a new pull request #622: Fineract-722
URL: https://github.com/apache/fineract/pull/622
 
 
   ## Description
   Fixes issue where global configurations were affecting state between integration tests. This caused LoanReschedulingWithinCenterTest to fail only on the first day of the month because the "skip-repayment-on-first-day-of-month" configuration was modified but never reset by GlobalConfigurationTest.
   Also updated other integration tests to reset and verify default global configurations.
   ## Checklist
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [x] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
   
   - [x] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
   
   - [x] API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been updated with details of any API changes.
   (N/A)
   
   - [x] Integration tests have been created/updated for verifying the changes made.
   
   - [x] All Integrations tests are passing with the new commits.
   
   - [x] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the list.)
   
   Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services