You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2016/02/11 00:44:24 UTC
Review Request 43452: Fixed parse error for docker image with volume
defined.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43452/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos
Description
-------
Fixed parse error for docker image with volume defined.
Diffs
-----
include/mesos/docker/v1.proto fab3b080cb451333a6eb7e098589a19a3e293341
Diff: https://reviews.apache.org/r/43452/diff/
Testing
-------
make check (ubuntu14.04 + clang-3.6)
Thanks,
Gilbert Song
Re: Review Request 43452: Fixed parse error for docker image with
volume defined.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43452/#review118765
-----------------------------------------------------------
include/mesos/docker/v1.proto (lines 50 - 55)
<https://reviews.apache.org/r/43452/#comment180074>
Let's simply remove it for now since it's not used.
- Jie Yu
On Feb. 10, 2016, 11:44 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43452/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2016, 11:44 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed parse error for docker image with volume defined.
>
>
> Diffs
> -----
>
> include/mesos/docker/v1.proto fab3b080cb451333a6eb7e098589a19a3e293341
>
> Diff: https://reviews.apache.org/r/43452/diff/
>
>
> Testing
> -------
>
> make check (ubuntu14.04 + clang-3.6)
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 43452: Removed `Volumes` in docker v1 manifest
protobuf.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43452/#review118786
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Feb. 11, 2016, 12:42 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43452/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2016, 12:42 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed `Volumes` in docker v1 manifest protobuf.
>
>
> Diffs
> -----
>
> include/mesos/docker/v1.proto fab3b080cb451333a6eb7e098589a19a3e293341
>
> Diff: https://reviews.apache.org/r/43452/diff/
>
>
> Testing
> -------
>
> make check (ubuntu14.04 + clang-3.6)
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 43452: Removed `Volumes` in docker v1 manifest
protobuf.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43452/
-----------------------------------------------------------
(Updated Feb. 10, 2016, 4:42 p.m.)
Review request for mesos and Jie Yu.
Summary (updated)
-----------------
Removed `Volumes` in docker v1 manifest protobuf.
Repository: mesos
Description (updated)
-------
Removed `Volumes` in docker v1 manifest protobuf.
Diffs (updated)
-----
include/mesos/docker/v1.proto fab3b080cb451333a6eb7e098589a19a3e293341
Diff: https://reviews.apache.org/r/43452/diff/
Testing
-------
make check (ubuntu14.04 + clang-3.6)
Thanks,
Gilbert Song