You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by oknet <gi...@git.apache.org> on 2017/03/15 08:33:39 UTC
[GitHub] trafficserver pull request #1583: Set HttpSM::tunnel_handler_post to handle ...
GitHub user oknet opened a pull request:
https://github.com/apache/trafficserver/pull/1583
Set HttpSM::tunnel_handler_post to handle write event for outputing HTTP 408 response.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/oknet/trafficserver i1583
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1583.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1583
----
commit d1912ffaa63580c4b973ab8df7fbf223933c6012
Author: Oknet Xu <xu...@skyguard.com.cn>
Date: 2017-03-15T08:31:31Z
Set HttpSM::tunnel_handler_post to handle write event for outputing HTTP 408 response.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
clang-analyzer build *successful*! https://ci.trafficserver.apache.org/job/clang-analyzer-github/324/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
RAT check *successful*! https://ci.trafficserver.apache.org/job/RAT-github/109/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
FreeBSD11 build *successful*! https://ci.trafficserver.apache.org/job/freebsd-github/1785/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by maskit <gi...@git.apache.org>.
Github user maskit commented on the issue:
https://github.com/apache/trafficserver/pull/1583
I might be able to reproduce the issue, but only with H2. I couldn't reproduce it with H1.
What I did are:
- Add sleep(5) into consume() of PostBuffer plugin
- Set proxy.config.http.transaction_no_activity_timeout_in and proxy.config.http.transaction_active_timeout_in very small (2~5 sec)
- Apply the change on this PR
- Run ATS with the modified PostBuffer plugin
- Send a big POST request with curl
The patch fixes an abort issue but ATS still aborts. (Fails at another assert.)
```
Fatal: HttpSM.cc:2725: failed assertion `post_transform_info.entry->in_tunnel == true`
2017-03-22 16:14:23.623562 traffic_server[68093:3635467] Fatal: HttpSM.cc:2725: failed assertion `post_transform_info.entry->in_tunnel == true`
```
```
(lldb) bt
* thread #14: tid = 0x37790b, 0x00007fffd5191dd6 libsystem_kernel.dylib`__pthread_kill + 10, name = '[ET_NET 11]', stop reason = signal SIGABRT
* frame #0: 0x00007fffd5191dd6 libsystem_kernel.dylib`__pthread_kill + 10
frame #1: 0x00007fffd527d787 libsystem_pthread.dylib`pthread_kill + 90
frame #2: 0x00007fffd50f7420 libsystem_c.dylib`abort + 129
frame #3: 0x000000000002abd0 libtsutil.7.dylib`ink_abort(message_format="%s:%d: failed assertion `%s`") + 368 at ink_error.cc:99
frame #4: 0x0000000000027a0f libtsutil.7.dylib`::_ink_assert(expression="post_transform_info.entry->in_tunnel == true", file="HttpSM.cc", line=2725) + 47 at ink_assert.cc:37
frame #5: 0x000000010014ca3e traffic_server`HttpSM::tunnel_handler_post_or_put(this=0x0000000005cfd9b0, p=0x0000000005cfef00) + 174 at HttpSM.cc:2725
frame #6: 0x000000010013fa06 traffic_server`HttpSM::tunnel_handler_post(this=0x0000000005cfd9b0, event=103, data=0x0000000003e2ded0) + 1062 at HttpSM.cc:2790
frame #7: 0x0000000100137708 traffic_server`HttpSM::main_handler(this=0x0000000005cfd9b0, event=103, data=0x0000000003e2ded0) + 776 at HttpSM.cc:2682
frame #8: 0x000000010001ef60 traffic_server`Continuation::handleEvent(this=0x0000000005cfd9b0, event=103, data=0x0000000003e2ded0) + 112 at I_Continuation.h:153
frame #9: 0x00000001001be69f traffic_server`Http2Stream::main_event_handler(this=0x0000000003e2db40, event=103, edata=0x0000000000b46aa0) + 1903 at Http2Stream.cc:88
frame #10: 0x000000010001ef60 traffic_server`Continuation::handleEvent(this=0x0000000003e2db40, event=103, data=0x0000000000b46aa0) + 112 at I_Continuation.h:153
frame #11: 0x0000000100375a15 traffic_server`EThread::process_event(this=0x0000000002d0c000, e=0x0000000000b46aa0, calling_code=103) + 405 at UnixEThread.cc:143
frame #12: 0x00000001003761dc traffic_server`EThread::execute(this=0x0000000002d0c000) + 972 at UnixEThread.cc:240
frame #13: 0x0000000100374f57 traffic_server`spawn_thread_internal(a=0x00000000037000c0) + 103 at Thread.cc:84
frame #14: 0x00007fffd527aaab libsystem_pthread.dylib`_pthread_body + 180
frame #15: 0x00007fffd527a9f7 libsystem_pthread.dylib`_pthread_start + 286
frame #16: 0x00007fffd527a1fd libsystem_pthread.dylib`thread_start + 13
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
AU check *failed*! https://ci.trafficserver.apache.org/job/autest-github/61/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
Linux build *failed*! https://ci.trafficserver.apache.org/job/linux-github/1653/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
clang format *successful*! https://ci.trafficserver.apache.org/job/clang-format-github/66/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by oknet <gi...@git.apache.org>.
Github user oknet commented on the issue:
https://github.com/apache/trafficserver/pull/1583
The vc_table is cleanup_all() and tunnel is chain_abort_all(p) before we call tunnel_handler_post_or_put(p).
```
vc_table.cleanup_all();
tunnel.chain_abort_all(p);
```
we should call tunnel_handler_post_or_put() only if event == HTTP_TUNNEL_EVENT_DONE.
and replace HttpSM.cc:2790 with "terminate_sm = true;"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
FreeBSD11 build *successful*! https://ci.trafficserver.apache.org/job/freebsd-github/1761/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
Intel CC build *failed*! https://ci.trafficserver.apache.org/job/icc-github/192/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
clang-analyzer build *successful*! https://ci.trafficserver.apache.org/job/clang-analyzer-github/347/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
clang format *successful*! https://ci.trafficserver.apache.org/job/clang-format-github/65/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
RAT check *successful*! https://ci.trafficserver.apache.org/job/RAT-github/78/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
clang-analyzer build *successful*! https://ci.trafficserver.apache.org/job/clang-analyzer-github/322/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
FreeBSD11 build *successful*! https://ci.trafficserver.apache.org/job/freebsd-github/1760/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
Intel CC build *failed*! https://ci.trafficserver.apache.org/job/icc-github/190/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1583
This is running on Docs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
Linux build *failed*! https://ci.trafficserver.apache.org/job/linux-github/1654/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
RAT check *successful*! https://ci.trafficserver.apache.org/job/RAT-github/77/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
AU check *successful*! https://ci.trafficserver.apache.org/job/autest-github/62/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1583: Set HttpSM::tunnel_handler_post to handle ...
Posted by oknet <gi...@git.apache.org>.
Github user oknet commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1583#discussion_r107694127
--- Diff: proxy/http/HttpSM.cc ---
@@ -2771,7 +2771,8 @@ HttpSM::tunnel_handler_post(int event, void *data)
}
if (event != HTTP_TUNNEL_EVENT_DONE) {
- if ((event == VC_EVENT_WRITE_COMPLETE) || (event == VC_EVENT_EOS)) {
+ if ((event == VC_EVENT_WRITE_COMPLETE) || (event == VC_EVENT_EOS) || (event == VC_EVENT_ERROR) ||
--- End diff --
I can rewrite it to switch-case :
```
switch (event) {
case VC_EVENT_WRITE_COMPLETE:
case VC_EVENT_EOS:
case VC_EVENT_ERROR:
case VC_EVENT_INACTIVITY_TIMEOUT:
case VC_EVENT_ACTIVE_TIMEOUT:
// do something
break;
default:
break;
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
Linux build *successful*! https://ci.trafficserver.apache.org/job/linux-github/1684/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
clang format *successful*! https://ci.trafficserver.apache.org/job/clang-format-github/89/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
clang-analyzer build *successful*! https://ci.trafficserver.apache.org/job/clang-analyzer-github/354/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by maskit <gi...@git.apache.org>.
Github user maskit commented on the issue:
https://github.com/apache/trafficserver/pull/1583
@oknet The assert has gone. At least it works with H2. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
AU check *successful*! https://ci.trafficserver.apache.org/job/autest-github/93/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
AU check *successful*! https://ci.trafficserver.apache.org/job/autest-github/87/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
Linux build *successful*! https://ci.trafficserver.apache.org/job/linux-github/1678/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
Intel CC build *successful*! https://ci.trafficserver.apache.org/job/icc-github/216/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by oknet <gi...@git.apache.org>.
Github user oknet commented on the issue:
https://github.com/apache/trafficserver/pull/1583
@zwoop yes, 7.1.x is ok.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
Intel CC build *failed*! https://ci.trafficserver.apache.org/job/icc-github/215/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
Linux build *failed*! https://ci.trafficserver.apache.org/job/linux-github/1655/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1583
I've been running with this on docs for a few days, with no problem. It does not seem to address the threads running at 100% CPU at times though. But assuming this fixes another problem, it seems safe and fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1583: Set HttpSM::tunnel_handler_post to handle ...
Posted by maskit <gi...@git.apache.org>.
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1583#discussion_r107818082
--- Diff: proxy/http/HttpSM.cc ---
@@ -2771,7 +2771,8 @@ HttpSM::tunnel_handler_post(int event, void *data)
}
if (event != HTTP_TUNNEL_EVENT_DONE) {
- if ((event == VC_EVENT_WRITE_COMPLETE) || (event == VC_EVENT_EOS)) {
+ if ((event == VC_EVENT_WRITE_COMPLETE) || (event == VC_EVENT_EOS) || (event == VC_EVENT_ERROR) ||
--- End diff --
I think we should add the inline function to make sure that the same condition is used under the same context, and to clarify the condition we expect.
The switch case style is more readable than current style though, it doesn't tell us what the case is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
clang-analyzer build *successful*! https://ci.trafficserver.apache.org/job/clang-analyzer-github/348/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
FreeBSD11 build *successful*! https://ci.trafficserver.apache.org/job/freebsd-github/1784/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
AU check *successful*! https://ci.trafficserver.apache.org/job/autest-github/63/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
Linux build *failed*! https://ci.trafficserver.apache.org/job/linux-github/1677/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
AU check *successful*! https://ci.trafficserver.apache.org/job/autest-github/86/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1583
This sounds like a 7.1.0 candidate?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1583: Set HttpSM::tunnel_handler_post to handle ...
Posted by oknet <gi...@git.apache.org>.
Github user oknet closed the pull request at:
https://github.com/apache/trafficserver/pull/1583
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
clang-analyzer build *successful*! https://ci.trafficserver.apache.org/job/clang-analyzer-github/323/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
Intel CC build *failed*! https://ci.trafficserver.apache.org/job/icc-github/191/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
clang format *successful*! https://ci.trafficserver.apache.org/job/clang-format-github/64/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1583: Set HttpSM::tunnel_handler_post to handle ...
Posted by mingzym <gi...@git.apache.org>.
Github user mingzym commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1583#discussion_r107705366
--- Diff: proxy/http/HttpSM.cc ---
@@ -2771,7 +2771,8 @@ HttpSM::tunnel_handler_post(int event, void *data)
}
if (event != HTTP_TUNNEL_EVENT_DONE) {
- if ((event == VC_EVENT_WRITE_COMPLETE) || (event == VC_EVENT_EOS)) {
+ if ((event == VC_EVENT_WRITE_COMPLETE) || (event == VC_EVENT_EOS) || (event == VC_EVENT_ERROR) ||
--- End diff --
switch case is much ATS style than any others, more clear for Human reading.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
RAT check *successful*! https://ci.trafficserver.apache.org/job/RAT-github/102/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
clang format *successful*! https://ci.trafficserver.apache.org/job/clang-format-github/90/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
FreeBSD11 build *successful*! https://ci.trafficserver.apache.org/job/freebsd-github/1791/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by oknet <gi...@git.apache.org>.
Github user oknet commented on the issue:
https://github.com/apache/trafficserver/pull/1583
@zwoop @SolidWallOfCode
In HttpSM::tunnel_handler_post(), calling tunnel_handler_post_or_put(p) before vc_table.cleanup_all() and tunnel.chain_abort_all(p) to avoid assert that @maskit met.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1583: Set HttpSM::tunnel_handler_post to handle ...
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1583#discussion_r107681516
--- Diff: proxy/http/HttpSM.cc ---
@@ -2771,7 +2771,8 @@ HttpSM::tunnel_handler_post(int event, void *data)
}
if (event != HTTP_TUNNEL_EVENT_DONE) {
- if ((event == VC_EVENT_WRITE_COMPLETE) || (event == VC_EVENT_EOS)) {
+ if ((event == VC_EVENT_WRITE_COMPLETE) || (event == VC_EVENT_EOS) || (event == VC_EVENT_ERROR) ||
--- End diff --
@shinrich and I discussed this a bit. It's a big ugly to have these two long conditionals that are identical but not obviously so. What I would recommend is adding an inline function like `isTxnTerminalEvent` that covers `EOS`, `ERROR`, `INACTIVITY_TIMEOUT` and `INACTIVITY_TIMEOUT` and have
```
if (event == VC_EVENT_WRITE_COMPLETE || isEventTxTerminal(event)) {
```
which would be easier to understand and easier to see the set of events are the same here and on line 2784. Our opinion is this would be useful in no small number of other places in the code as well and help prevent problems like this in the future.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
FreeBSD11 build *successful*! https://ci.trafficserver.apache.org/job/freebsd-github/1759/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
RAT check *successful*! https://ci.trafficserver.apache.org/job/RAT-github/103/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
RAT check *successful*! https://ci.trafficserver.apache.org/job/RAT-github/79/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
Intel CC build *successful*! https://ci.trafficserver.apache.org/job/icc-github/222/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1583
clang format *successful*! https://ci.trafficserver.apache.org/job/clang-format-github/96/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---