[GitHub] [hudi] danny0405 commented on a diff in pull request #7295: [HUDI-5275][flink]Fix reading data using the HoodieHiveCatalog will cause the Spark write to fail

[GitBox <gi...@apache.org>]

danny0405 commented on code in PR #7295:
URL: https://github.com/apache/hudi/pull/7295#discussion_r1031118352


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/catalog/HoodieHiveCatalog.java:
##########
@@ -382,6 +383,8 @@ private Table translateSparkTable2Flink(ObjectPath tablePath, Table hiveTable) {
         parameters.putAll(TableOptionProperties.translateSparkTableProperties2Flink(hiveTable));
         String path = hiveTable.getSd().getLocation();
         parameters.put(PATH.key(), path);
+        Map<String, String> hoodieProps = loadFromHoodiePropertieFile(path, hiveConf);
+        parameters.putAll(TableOptionProperties.translateSparkTableProperties2Flink(hoodieProps));
         if (!parameters.containsKey(FlinkOptions.HIVE_STYLE_PARTITIONING.key())) {

Review Comment:
   Do we need to put the explicit table options here ? Which function needs this config and where we miss it then ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org