You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/05/14 12:56:24 UTC

[GitHub] [incubator-apisix] ShiningRush opened a new pull request #1591: fix: add default checkw for default and hide install command

ShiningRush opened a new pull request #1591:
URL: https://github.com/apache/incubator-apisix/pull/1591


   1. hide install command 
   2. add default check for install


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] membphis merged pull request #1591: fix: add default checkw for default and hide install command

Posted by GitBox <gi...@apache.org>.
membphis merged pull request #1591:
URL: https://github.com/apache/incubator-apisix/pull/1591


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1591: fix: add default checkw for default and hide install command

Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1591:
URL: https://github.com/apache/incubator-apisix/pull/1591#discussion_r429987017



##########
File path: Makefile
##########
@@ -108,9 +108,8 @@ reload: default
 	$(OR_EXEC) -p $$PWD/  -c $$PWD/conf/nginx.conf -s reload
 
 
-### install:          Install the apisix

Review comment:
       this line is useful, we can not delete it.
   
   ![image](https://user-images.githubusercontent.com/6814606/82825642-2e018000-9ede-11ea-8539-a27b1960a5d5.png)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] agile6v commented on pull request #1591: fix: add default checkw for default and hide install command

Posted by GitBox <gi...@apache.org>.
agile6v commented on pull request #1591:
URL: https://github.com/apache/incubator-apisix/pull/1591#issuecomment-630190663


   Please add a warning message if install command is executed. 
   
   Thanks. 
   
   Refer to: https://github.com/apache/incubator-apisix/issues/1449#issuecomment-613901334


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] ShiningRush commented on pull request #1591: fix: add default checkw for default and hide install command

Posted by GitBox <gi...@apache.org>.
ShiningRush commented on pull request #1591:
URL: https://github.com/apache/incubator-apisix/pull/1591#issuecomment-630768204


   Hi, agile, the command  `default` has already checked whether openresty is installed, I add default check before install command executing,I think it is enough.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org