You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by dlmarion <gi...@git.apache.org> on 2016/08/15 16:55:49 UTC
[GitHub] accumulo pull request #138: ACCUMULO-4406: Add instance number to .out and ....
GitHub user dlmarion opened a pull request:
https://github.com/apache/accumulo/pull/138
ACCUMULO-4406: Add instance number to .out and .err files
@mjwall @joshelser
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/accumulo ACCUMULO-4406
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/accumulo/pull/138.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #138
----
commit cd949cd40e15cb0e3acb8e9292abec95e19f41d1
Author: Dave Marion <dl...@apache.org>
Date: 2016-08-15T16:51:33Z
ACCUMULO-4406: Add instance number to .out and .err files
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request #138: ACCUMULO-4406: Add instance number to .out and ....
Posted by dlmarion <gi...@git.apache.org>.
Github user dlmarion commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/138#discussion_r74797105
--- Diff: assemble/bin/start-daemon.sh ---
@@ -103,6 +103,9 @@ if [[ "$SERVICE" != "tserver" || $NUM_TSERVERS -eq 1 ]]; then
fi
echo "Starting $SERVICE on $HOST"
+ OUTFILE="${ACCUMULO_LOG_DIR}/${SERVICE}_1_${LOGHOST}.out"
--- End diff --
Ok, so just need to add rotate_log calls at 108 and 146?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #138: ACCUMULO-4406: Add instance number to .out and .err fil...
Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on the issue:
https://github.com/apache/accumulo/pull/138
LGTM, will put it up on my 180rc1 cluster and test it out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request #138: ACCUMULO-4406: Add instance number to .out and ....
Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/138#discussion_r74807060
--- Diff: assemble/bin/start-daemon.sh ---
@@ -103,6 +103,9 @@ if [[ "$SERVICE" != "tserver" || $NUM_TSERVERS -eq 1 ]]; then
fi
echo "Starting $SERVICE on $HOST"
+ OUTFILE="${ACCUMULO_LOG_DIR}/${SERVICE}_1_${LOGHOST}.out"
--- End diff --
Ok, that sounds reasonable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request #138: ACCUMULO-4406: Add instance number to .out and ....
Posted by dlmarion <gi...@git.apache.org>.
Github user dlmarion commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/138#discussion_r74796945
--- Diff: assemble/bin/start-daemon.sh ---
@@ -103,6 +103,9 @@ if [[ "$SERVICE" != "tserver" || $NUM_TSERVERS -eq 1 ]]; then
fi
echo "Starting $SERVICE on $HOST"
+ OUTFILE="${ACCUMULO_LOG_DIR}/${SERVICE}_1_${LOGHOST}.out"
--- End diff --
I see it, I'll take a look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request #138: ACCUMULO-4406: Add instance number to .out and ....
Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/138#discussion_r74798224
--- Diff: assemble/bin/start-daemon.sh ---
@@ -103,6 +103,9 @@ if [[ "$SERVICE" != "tserver" || $NUM_TSERVERS -eq 1 ]]; then
fi
echo "Starting $SERVICE on $HOST"
+ OUTFILE="${ACCUMULO_LOG_DIR}/${SERVICE}_1_${LOGHOST}.out"
--- End diff --
I think we can just bring the entire OUTFILE/ERRFILE definition and `rotate_log` call into the if-branch like you did for the else-branch, and remove the original declaration.
Although, I wonder why we even need to two branches? Didn't this problem come about because we weren't using the same logic? If we hit the "start multiple tservers" branch and only start 1 tserver, would it do what we want?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #138: ACCUMULO-4406: Add instance number to .out and .err fil...
Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on the issue:
https://github.com/apache/accumulo/pull/138
@dlmarion I can pull this in when my test of ACCUMULO-4405 finishes if you'd like.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request #138: ACCUMULO-4406: Add instance number to .out and ....
Posted by dlmarion <gi...@git.apache.org>.
Github user dlmarion commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/138#discussion_r74800933
--- Diff: assemble/bin/start-daemon.sh ---
@@ -103,6 +103,9 @@ if [[ "$SERVICE" != "tserver" || $NUM_TSERVERS -eq 1 ]]; then
fi
echo "Starting $SERVICE on $HOST"
+ OUTFILE="${ACCUMULO_LOG_DIR}/${SERVICE}_1_${LOGHOST}.out"
--- End diff --
I think we should leave 86-91 and remove 106-111. 106-111 will add _1 for all services when there is only one tserver. If we do this, then you will get .out and .err per tserver instance and everything else will remain the same.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request #138: ACCUMULO-4406: Add instance number to .out and ....
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/accumulo/pull/138
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #138: ACCUMULO-4406: Add instance number to .out and .err fil...
Posted by mjwall <gi...@git.apache.org>.
Github user mjwall commented on the issue:
https://github.com/apache/accumulo/pull/138
Walked through with @dlmarion, LGTM but I haven't run it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request #138: ACCUMULO-4406: Add instance number to .out and ....
Posted by dlmarion <gi...@git.apache.org>.
Github user dlmarion commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/138#discussion_r74798567
--- Diff: assemble/bin/start-daemon.sh ---
@@ -103,6 +103,9 @@ if [[ "$SERVICE" != "tserver" || $NUM_TSERVERS -eq 1 ]]; then
fi
echo "Starting $SERVICE on $HOST"
+ OUTFILE="${ACCUMULO_LOG_DIR}/${SERVICE}_1_${LOGHOST}.out"
--- End diff --
The if section is used when there is only one tserver and for all the services (master, gc, etc).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request #138: ACCUMULO-4406: Add instance number to .out and ....
Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/138#discussion_r74796177
--- Diff: assemble/bin/start-daemon.sh ---
@@ -103,6 +103,9 @@ if [[ "$SERVICE" != "tserver" || $NUM_TSERVERS -eq 1 ]]; then
fi
echo "Starting $SERVICE on $HOST"
+ OUTFILE="${ACCUMULO_LOG_DIR}/${SERVICE}_1_${LOGHOST}.out"
--- End diff --
Actually, this isn't right. The call to `rotate_log` on lines 90,91 would get lost.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request #138: ACCUMULO-4406: Add instance number to .out and ....
Posted by dlmarion <gi...@git.apache.org>.
Github user dlmarion commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/138#discussion_r74800531
--- Diff: assemble/bin/start-daemon.sh ---
@@ -103,6 +103,9 @@ if [[ "$SERVICE" != "tserver" || $NUM_TSERVERS -eq 1 ]]; then
fi
echo "Starting $SERVICE on $HOST"
+ OUTFILE="${ACCUMULO_LOG_DIR}/${SERVICE}_1_${LOGHOST}.out"
--- End diff --
If you don't want the _1 for just one tserver, we could remove the changes to the top section.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #138: ACCUMULO-4406: Add instance number to .out and .err fil...
Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on the issue:
https://github.com/apache/accumulo/pull/138
Some day Github will let you change the destination branch after opening the PR (maybe) :P
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request #138: ACCUMULO-4406: Add instance number to .out and ....
Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/138#discussion_r74799347
--- Diff: assemble/bin/start-daemon.sh ---
@@ -103,6 +103,9 @@ if [[ "$SERVICE" != "tserver" || $NUM_TSERVERS -eq 1 ]]; then
fi
echo "Starting $SERVICE on $HOST"
+ OUTFILE="${ACCUMULO_LOG_DIR}/${SERVICE}_1_${LOGHOST}.out"
--- End diff --
Ahh, ok, I forgot about the other services. This is what I was thinking. You can also remove lines 86-91 as they are unnecessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #138: ACCUMULO-4406: Add instance number to .out and .err fil...
Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on the issue:
https://github.com/apache/accumulo/pull/138
@dlmarion Is this what you expect to see?
```
% ll logs run
logs:
total 472
-rw-r--r-- 1 jelser staff 23K Aug 15 14:41 gc_1_hw10447.local.debug.log
-rw-r--r-- 1 jelser staff 21K Aug 15 14:41 gc_1_hw10447.local.log
-rw-r--r-- 1 jelser staff 0B Aug 15 14:41 gc_localhost.err
-rw-r--r-- 1 jelser staff 0B Aug 15 14:41 gc_localhost.out
-rw-r--r-- 1 jelser staff 0B Aug 15 14:41 hw10447.local.audit
-rw-r--r-- 1 jelser staff 27K Aug 15 14:41 master_1_hw10447.local.debug.log
-rw-r--r-- 1 jelser staff 23K Aug 15 14:41 master_1_hw10447.local.log
-rw-r--r-- 1 jelser staff 0B Aug 15 14:41 master_localhost.err
-rw-r--r-- 1 jelser staff 0B Aug 15 14:41 master_localhost.out
-rw-r--r-- 1 jelser staff 28K Aug 15 14:41 monitor_hw10447.local.debug.log
-rw-r--r-- 1 jelser staff 25K Aug 15 14:41 monitor_hw10447.local.log
-rw-r--r-- 1 jelser staff 0B Aug 15 14:41 monitor_localhost.err
-rw-r--r-- 1 jelser staff 0B Aug 15 14:41 monitor_localhost.out
-rw-r--r-- 1 jelser staff 21K Aug 15 14:41 tracer_1_hw10447.local.debug.log
-rw-r--r-- 1 jelser staff 20K Aug 15 14:41 tracer_1_hw10447.local.log
-rw-r--r-- 1 jelser staff 0B Aug 15 14:41 tracer_localhost.err
-rw-r--r-- 1 jelser staff 0B Aug 15 14:41 tracer_localhost.out
-rw-r--r-- 1 jelser staff 13K Aug 15 14:41 tserver_1_hw10447.local.debug.log
-rw-r--r-- 1 jelser staff 10K Aug 15 14:41 tserver_1_hw10447.local.log
-rw-r--r-- 1 jelser staff 0B Aug 15 14:41 tserver_localhost.err
-rw-r--r-- 1 jelser staff 0B Aug 15 14:41 tserver_localhost.out
run:
total 40
-rw-r--r-- 1 jelser staff 6B Aug 15 14:41 accumulo-jelser-gc.pid
-rw-r--r-- 1 jelser staff 6B Aug 15 14:41 accumulo-jelser-master.pid
-rw-r--r-- 1 jelser staff 6B Aug 15 14:41 accumulo-jelser-monitor.pid
-rw-r--r-- 1 jelser staff 6B Aug 15 14:41 accumulo-jelser-tracer.pid
-rw-r--r-- 1 jelser staff 6B Aug 15 14:41 accumulo-jelser-tserver.pid
```
The "_1" on tracer, master, and gc seem unexpected given you previous comment about avoiding them on the .out/.err files for non-tserver processes. Also, the monitor log file doesn't have the extra "_1" which seems out of place (but correct).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #138: ACCUMULO-4406: Add instance number to .out and .err fil...
Posted by dlmarion <gi...@git.apache.org>.
Github user dlmarion commented on the issue:
https://github.com/apache/accumulo/pull/138
Please do.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #138: ACCUMULO-4406: Add instance number to .out and .err fil...
Posted by dlmarion <gi...@git.apache.org>.
Github user dlmarion commented on the issue:
https://github.com/apache/accumulo/pull/138
No, not what I expected.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #138: ACCUMULO-4406: Add instance number to .out and .err fil...
Posted by dlmarion <gi...@git.apache.org>.
Github user dlmarion commented on the issue:
https://github.com/apache/accumulo/pull/138
Cool, thanks @joshelser
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---