You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/03/26 23:55:57 UTC

[GitHub] [iotdb] CRZbulabula commented on a change in pull request #5347: [IOTDB-2780] Config node ratis consensus protocol implementation

CRZbulabula commented on a change in pull request #5347:
URL: https://github.com/apache/iotdb/pull/5347#discussion_r835825603



##########
File path: confignode/src/main/java/org/apache/iotdb/confignode/conf/ConfigNodeDescriptor.java
##########
@@ -175,6 +175,24 @@ private void loadProps() {
               properties.getProperty(
                   "data_region_count", String.valueOf(conf.getDataRegionCount()))));
 
+      String addresses = properties.getProperty("config_node_group_address_list", null);

Review comment:
       Of course, I think we need a common .properties file reading process in iotdb-common. But I think this job isn't urgent currently, we could optimize both IoTDBDescriptor and ConfigNodeDescriptor later.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org