You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/10/21 02:03:43 UTC

[GitHub] [pulsar] Jason918 commented on a change in pull request #12430: In the class ServerCnx, use the authenticateOriginalAuthData variable.

Jason918 commented on a change in pull request #12430:
URL: https://github.com/apache/pulsar/pull/12430#discussion_r733265453



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
##########
@@ -814,7 +814,7 @@ protected void handleConnect(CommandConnect connect) {
             //  1. client is coming through a proxy
             //  2. we require to validate the original credentials
             //  3. no credentials were passed
-            if (connect.hasOriginalPrincipal() && service.getPulsar().getConfig().isAuthenticateOriginalAuthData()) {
+            if (connect.hasOriginalPrincipal() && authenticateOriginalAuthData) {

Review comment:
       Does `isAuthenticateOriginalAuthData` can be updated online? If so, it's better not to store it in local variable.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org