You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/03/22 06:52:55 UTC

[GitHub] [fineract-cn-mobile] varsvat commented on a change in pull request #169: Fix-303: Image select from Gallery Downloads crash fixed

varsvat commented on a change in pull request #169:
URL: https://github.com/apache/fineract-cn-mobile/pull/169#discussion_r598460878



##########
File path: app/src/main/java/org/apache/fineract/utils/FileUtils.java
##########
@@ -224,7 +248,7 @@ public static void writeInputStreamDataToFile(InputStream in, File file) {
             out.close();
             in.close();
         } catch (Exception e) {
-            Log.d(LOG_TAG, e.getLocalizedMessage());
+            Logger.getLogger(e.getLocalizedMessage());

Review comment:
       All other looks good to me but why did you replace Log with logger , it isn't a essential change . So i'd suggest you keep t earlier one only so that it will be easy and straight forward to merge this PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org